feat(NODE-6757): support tags for perf.send #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
requested changes
Feb 13, 2025
Collaborator
baileympearson
left a comment
baileympearson
left a comment
There was a problem hiding this comment.
Can we add a test that demonstrates that a benchmark's results include the tags in the correct location?
The test in suite.test.ts is asserting that the results file contains the results, but it doesn't assert that the results contain the tags.
baileympearson
added
the
Primary Review
dariakp
previously requested changes
Feb 14, 2025
baileympearson
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Supports tags for perf.send results
Is there new documentation needed for these changes?
What is the motivation for this change?
Perf monitoring improvements NODE-6757
Double check the following
npm run check:eslintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript