Skip to content

feat(NODE-6757): support tags for perf.send #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 14, 2025
Merged

feat(NODE-6757): support tags for perf.send #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1314113
support tags
W-A-James Feb 12, 2025
69d5bc2
lint
W-A-James Feb 12, 2025
52cd876
add test to verify that tags are added to results
W-A-James Feb 13, 2025
8722159
pull tags off benchmarkSpec
W-A-James Feb 13, 2025
0d68dbe
remove obsolete test
W-A-James Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/bson-bench/src/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,7 @@ export type BenchmarkSpecification = {
* local package */
library: string;
installLocation?: string;
tags?: string[];
};

export interface RunBenchmarkMessage {
Expand Down
1 change: 1 addition & 0 deletions packages/bson-bench/src/task.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ export class Task {
const perfSendResults: PerfSendResult = {
info: {
test_name: this.testName,
tags: this.benchmark.tags,
args: {
warmup: this.benchmark.warmup,
iterations: this.benchmark.iterations,
Expand Down
3 changes: 2 additions & 1 deletion packages/bson-bench/test/unit/suite.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,8 @@ describe('Suite', function () {
warmup: 10,
iterations: 10,
library: '[email protected]',
options: {}
options: {},
tags: ['test']
};
suite
.task({
Expand Down
10 changes: 8 additions & 2 deletions packages/bson-bench/test/unit/task.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@ describe('Task', function () {
operation,
warmup: 100,
iterations: 100,
options: {}
options: {},
tags: ['test']
}
];
})
Expand Down Expand Up @@ -210,7 +211,8 @@ describe('Task', function () {
operation: 'deserialize',
warmup: 1,
iterations: 1,
options
options,
tags: ['test', 'test2']
});

task.result = {
Expand All @@ -226,6 +228,10 @@ describe('Task', function () {
expect(results.info).to.haveOwnProperty('args');
});

it('returns the tags in the info.tags field', function () {
expect(results.info.tags).to.deep.equal(['test', 'test2']);
});

it('returns options provided in constructor in the info.args field', function () {
expect(results.info.args).to.haveOwnProperty('warmup');
expect(results.info.args).to.haveOwnProperty('iterations');
Expand Down