Skip to content

Conversation

nirinchev
Copy link
Collaborator

Proposed changes

Checklist

@Copilot Copilot AI review requested due to automatic review settings September 5, 2025 07:22
@nirinchev nirinchev requested a review from a team as a code owner September 5, 2025 07:22
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Smithery Dockerfile to align with the official Docker image structure and security practices.

  • Updates user creation commands to use addgroup/adduser pattern instead of single adduser command
  • Changes working directory from /app to /home/mcp for better security practices
  • Updates the COPY command in the production stage to reference the new working directory path

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.


RUN adduser -D mcpuser
USER mcpuser
RUN addgroup -S mcp && adduser -S mcp -G mcp
Copy link

Copilot AI Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When using a non-root user, ensure the working directory is owned by that user. Add RUN chown -R mcp:mcp /home/mcp after creating the user to ensure proper permissions.

Copilot uses AI. Check for mistakes.

@coveralls
Copy link
Collaborator

coveralls commented Sep 5, 2025

Pull Request Test Coverage Report for Build 17657973871

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 185 unchanged lines in 17 files lost coverage.
  • Overall coverage increased (+0.4%) to 81.59%

Files with Coverage Reduction New Missed Lines %
src/tools/atlas/create/createAccessList.ts 1 90.91%
src/tools/atlas/read/inspectAccessList.ts 3 86.67%
src/tools/atlas/create/createDBUser.ts 4 93.55%
src/tools/atlas/read/listAlerts.ts 5 66.67%
src/telemetry/eventCache.ts 6 82.61%
src/resources/common/exportedData.ts 7 68.47%
src/tools/atlas/read/listDBUsers.ts 8 80.3%
src/tools/atlas/read/listProjects.ts 11 67.19%
src/common/logger.ts 12 92.97%
src/tools/atlas/atlasTool.ts 12 26.67%
Totals Coverage Status
Change from base Build 17476889967: 0.4%
Covered Lines: 4866
Relevant Lines: 5864

💛 - Coveralls

@nirinchev nirinchev enabled auto-merge (squash) September 8, 2025 16:29
@nirinchev nirinchev merged commit 62a57d8 into main Sep 12, 2025
18 checks passed
@nirinchev nirinchev deleted the ni/smithery-dockerfile branch September 12, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants