-
Notifications
You must be signed in to change notification settings - Fork 129
chore: update smithery dockerfile to be closer to the official one #524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Smithery Dockerfile to align with the official Docker image structure and security practices.
- Updates user creation commands to use addgroup/adduser pattern instead of single adduser command
- Changes working directory from
/app
to/home/mcp
for better security practices - Updates the COPY command in the production stage to reference the new working directory path
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
.smithery/Dockerfile
Outdated
|
||
RUN adduser -D mcpuser | ||
USER mcpuser | ||
RUN addgroup -S mcp && adduser -S mcp -G mcp |
Copilot
AI
Sep 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When using a non-root user, ensure the working directory is owned by that user. Add RUN chown -R mcp:mcp /home/mcp
after creating the user to ensure proper permissions.
Copilot uses AI. Check for mistakes.
Pull Request Test Coverage Report for Build 17657973871Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Proposed changes
Checklist