Skip to content

chore: update smithery dockerfile to be closer to the official one #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 12, 2025
Merged

chore: update smithery dockerfile to be closer to the official one #524

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4181a12
chore: update smithery dockerfile to be closer to the official one
nirinchev Sep 5, 2025
ef0b4a9
address copilot suggestions
nirinchev Sep 8, 2025
7617674
Add mcp user to runner container
nirinchev Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .smithery/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@
# ----- Build Stage -----
FROM node:lts-alpine AS builder

RUN adduser -D mcpuser
USER mcpuser
RUN addgroup -S mcp && adduser -S mcp -G mcp
Copy link

Copilot AI Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When using a non-root user, ensure the working directory is owned by that user. Add RUN chown -R mcp:mcp /home/mcp after creating the user to ensure proper permissions.

Copilot uses AI. Check for mistakes.

USER mcp

WORKDIR /app
WORKDIR /home/mcp

# Copy package and configuration
COPY ../package.json ../package-lock.json ../tsconfig.json ../tsconfig.build.json ./
Expand All @@ -20,7 +20,7 @@ RUN npm ci && npm run build
FROM node:lts-alpine

# Copy built artifacts
COPY --from=builder /app/dist ./dist
COPY --from=builder /home/mcp/dist ./dist

# Copy package.json for production install
COPY ../package.json ../package-lock.json ./
Expand Down
Loading