chore: Update to Go 1.24.6 and Go linter to 2.3.1 #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lantoli
commented
Aug 11, 2025
| @@ -11,7 +12,7 @@ import ( | |||
|
|
|||
| func RunTF(args ...string) (string, error) { | |||
| args = append([]string{"tf"}, args...) | |||
| cmd := exec.Command("atlas", args...) | |||
| cmd := exec.CommandContext(context.Background(), "atlas", args...) | |||
There was a problem hiding this comment.
fix linter issue:
os/exec.Command must not be called. use os/exec.CommandContext (noctx)
|
snyk false positives |
There was a problem hiding this comment.
Pull Request Overview
Updates the project's Go version from 1.24.1 to 1.24.6 and upgrades the golangci-lint tool from v2.1.6 to v2.3.1 for improved code quality tooling.
- Updated Go runtime version to 1.24.6
- Upgraded golangci-lint to v2.3.1 in both Makefile and GitHub workflow
- Modified test helper to use context-aware command execution
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| go.mod | Updates Go version requirement from 1.24.1 to 1.24.6 |
| Makefile | Updates GOLANGCI_VERSION from v2.1.6 to v2.3.1 |
| .github/workflows/code-health.yml | Updates golangci-lint action version to v2.3.1 |
| test/e2e/e2e_helper.go | Replaces exec.Command with exec.CommandContext for better context handling |
lantoli
commented
Aug 12, 2025
| *.log | ||
| *.mdc | ||
| __debug_* | ||
| *~ |
There was a problem hiding this comment.
common ignore files as in Terraform repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update to Go 1.24.6 and Go linter to 2.3.1
Link to any related issue(s): CLOUDP-337347
Type of change:
Required Checklist:
Further comments