Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/code-health.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ jobs:
- name: golangci-lint
uses: golangci/golangci-lint-action@4afd733a84b1f43292c63897423277bb7f4313a9
with:
version: v2.1.6 # Also update GOLANGCI_VERSION variable in GNUmakefile when updating this version
version: v2.3.1 # Also update GOLANGCI_VERSION variable in GNUmakefile when updating this version
- name: actionlint
run: |
make tools
Expand Down
11 changes: 11 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,14 @@
bin
bin-plugin
.vscode
.DS_Store
.idea
.windsurf
CLAUDE.md
.claude
*.env
*.bak
*.log
*.mdc
__debug_*
*~
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

common ignore files as in Terraform repo

2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ CLI_DESTINATION=./bin/$(CLI_BINARY_NAME)
MANIFEST_FILE?=./bin/manifest.yml
WIN_MANIFEST_FILE?=./bin/manifest.windows.yml

GOLANGCI_VERSION=v2.1.6 # Also update golangci-lint GH action in code-health.yml when updating this version
GOLANGCI_VERSION=v2.3.1 # Also update golangci-lint GH action in code-health.yml when updating this version

.PHONY: build
build: ## Generate the binary in ./bin
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/mongodb-labs/atlas-cli-plugin-terraform

go 1.24.1
go 1.24.6

require (
github.com/fsnotify/fsnotify v1.9.0
Expand Down
3 changes: 2 additions & 1 deletion test/e2e/e2e_helper.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package e2e

import (
"context"
"os/exec"
"testing"

Expand All @@ -11,7 +12,7 @@ import (

func RunTF(args ...string) (string, error) {
args = append([]string{"tf"}, args...)
cmd := exec.Command("atlas", args...)
cmd := exec.CommandContext(context.Background(), "atlas", args...)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix linter issue:

os/exec.Command must not be called. use os/exec.CommandContext (noctx)

resp, err := cmd.CombinedOutput()
return string(resp), err
}
Expand Down