Skip to content

Conversation

baileympearson
Copy link
Contributor

Description

What is changing?

Is there new documentation needed for these changes?

What is the motivation for this change?

Release Highlight

Fill in title or leave empty for no highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson changed the title deps(NODE-xxxx): FY26Q2 lint-related dependency updates deps(NODE-6940): FY26Q2 lint-related dependency updates Apr 30, 2025
@baileympearson baileympearson marked this pull request as ready for review April 30, 2025 16:31
@baileympearson baileympearson requested a review from a team as a code owner April 30, 2025 16:31
@nbbeeken nbbeeken self-assigned this May 1, 2025
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label May 1, 2025
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conflicts, otherwise LGTM. nice that we catch the mistaken for-await now

@baileympearson baileympearson requested a review from nbbeeken May 2, 2025 14:59
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the lock file is "out of sync" according to the check-deps CI

@durran durran assigned durran and unassigned nbbeeken May 4, 2025
@durran
Copy link
Member

durran commented May 4, 2025

the lock file is "out of sync" according to the check-deps CI

Still the same happening.

@durran durran dismissed nbbeeken’s stale review May 5, 2025 16:22

Taking over primary.

@durran durran merged commit 6a35701 into main May 5, 2025
27 of 28 checks passed
@durran durran deleted the lint-related-deps branch May 5, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Primary Review In Review with primary reviewer, not yet ready for team's eyes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants