Skip to content

DRIVERS-3131: No explicitly provided properties with MONGODB-AWS #1847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 8, 2025
Merged

DRIVERS-3131: No explicitly provided properties with MONGODB-AWS #1847

merged 11 commits into from
Oct 8, 2025
+46 −50

Conversation

durran
Copy link
Member

@durran durran commented Sep 30, 2025 •
edited
Loading

Removes supplying credentials for MONGODB-AWS in the URI or client options in the auth spec and adds new tests.

Tools changes: mongodb-labs/drivers-evergreen-tools#691

Node implementation: mongodb/node-mongodb-native#4689

Please complete the following before merging:

  • Is the relevant DRIVERS ticket in the PR title?
  • Update changelog.
  • Test changes in at least one language driver.
  • Test these changes against all server versions and topologies (including standalone, replica set, and sharded
    clusters).

@durran durran marked this pull request as ready for review September 30, 2025 16:39
@durran durran requested a review from a team as a code owner September 30, 2025 16:39
@durran durran requested review from JamesKovacs and removed request for a team September 30, 2025 16:39
@dariakp dariakp requested review from dariakp and removed request for JamesKovacs September 30, 2025 18:02
dariakp
dariakp requested changes Sep 30, 2025
View reviewed changes
@dariakp dariakp changed the title DRIVERS-3131: No URI credentials with MONGODB-AWS DRIVERS-3131: No explicitly provided properties with MONGODB-AWS Sep 30, 2025
@durran durran requested a review from dariakp October 1, 2025 14:25
dariakp
dariakp requested changes Oct 1, 2025
View reviewed changes
@blink1073 blink1073 self-requested a review October 1, 2025 20:03
@durran durran requested a review from dariakp October 6, 2025 19:06
blink1073
blink1073 reviewed Oct 6, 2025
View reviewed changes
dariakp
dariakp requested changes Oct 6, 2025
View reviewed changes
@durran
Copy link
Member Author

durran commented Oct 6, 2025

#1847 (comment)

This has been fixed.

@durran durran requested a review from dariakp October 6, 2025 22:06
dariakp
dariakp requested changes Oct 7, 2025
View reviewed changes
@durran
Copy link
Member Author

durran commented Oct 7, 2025

#1847 (comment) Yes, just pushed.

@dariakp dariakp requested a review from blink1073 October 8, 2025 16:45
blink1073
blink1073 approved these changes Oct 8, 2025
View reviewed changes
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dariakp dariakp merged commit 2a83694 into master Oct 8, 2025
6 checks passed
@dariakp dariakp deleted the DRIVERS-3131 branch October 8, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 approved these changes

@dariakp dariakp dariakp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@durran @blink1073 @dariakp