Track release history #2404
Merged
Track release history #2404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kybishop
commented
Dec 5, 2025
kybishop
commented
kybishop
force-pushed
the
release-history
branch
from
62862a9 to
08e7984
Compare
kybishop
commented
Dec 6, 2025
| @@ -0,0 +1,23 @@ | |||
| defmodule NervesHub.Repo.Migrations.AddCascadeDeleteToDeploymentReleases do | |||
Contributor
Author
There was a problem hiding this comment.
Foreign key validation does not need to be separated out to a second migration because there are no deployment_release records until after this PR.
nshoes
approved these changes
Dec 9, 2025
Contributor
nshoes
left a comment
nshoes
left a comment
There was a problem hiding this comment.
This LGTM. I'll publish and run through a few tests in our QA.
Contributor
|
Looks good! |
nshoes
reviewed
Dec 9, 2025
lib/nerves_hub_web/components/deployment_group_page/release_history.ex
Outdated
Show resolved
Hide resolved
…story.ex Co-authored-by: Nate Shoemaker <[email protected]>
Co-authored-by: Nate Shoemaker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.