Skip to content

Conversation

TimPansino
Copy link
Contributor

@TimPansino TimPansino commented Apr 11, 2025

Overview

  • Enable ruff's built in linter rules.
    • Remove unicode characters in sample AI responses.
    • Disable 1 instance of a dangling asyncio task rule violation as intentional.
    • Fix all other violations.
  • Permanently disable flake8-self linter rules in ruff.
    • Only rule is private member access, which is done intentionally and would therefore be disabled. Disable entire linter instead.
  • Remove GitHub status reporter for Megalinter and just use comment reporter.
    • Status reporter seems to frequently fail to update and is deprecated.

@TimPansino TimPansino requested a review from a team as a code owner April 11, 2025 21:54
Copy link

github-actions bot commented Apr 11, 2025

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 6 0 0 0.92s
✅ MARKDOWN markdownlint 7 0 0 0 1.25s
✅ MARKDOWN markdown-link-check 7 0 0 25.83s
✅ PYTHON ruff 922 0 0 0 0.99s
✅ PYTHON ruff-format 922 0 0 0 0.31s
✅ YAML prettier 13 0 0 0 1.35s
✅ YAML v8r 13 0 0 6.24s
✅ YAML yamllint 13 0 0 0.62s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@mergify mergify bot added merge-conflicts Merge conflicts detected. tests-failing Tests failing in CI. and removed merge-conflicts Merge conflicts detected. labels Apr 17, 2025
@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2025

Codecov Report

❌ Patch coverage is 85.71429% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.35%. Comparing base (5661e81) to head (411560b).

Files with missing lines Patch % Lines
newrelic/hooks/messagebroker_pika.py 66.66% 2 Missing ⚠️
newrelic/core/agent.py 66.66% 1 Missing ⚠️
newrelic/core/stats_engine.py 85.71% 1 Missing ⚠️
newrelic/core/trace_cache.py 0.00% 1 Missing ⚠️
newrelic/hooks/adapter_cherrypy.py 0.00% 1 Missing ⚠️
newrelic/hooks/adapter_gevent.py 50.00% 1 Missing ⚠️
newrelic/hooks/adapter_wsgiref.py 0.00% 1 Missing ⚠️
newrelic/hooks/application_gearman.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1356   +/-   ##
=======================================
  Coverage   81.34%   81.35%           
=======================================
  Files         208      208           
  Lines       23585    23585           
  Branches     3719     3719           
=======================================
+ Hits        19185    19187    +2     
+ Misses       3144     3142    -2     
  Partials     1256     1256           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify bot added the merge-conflicts Merge conflicts detected. label Apr 21, 2025
@mergify mergify bot removed the merge-conflicts Merge conflicts detected. label Apr 22, 2025
@TimPansino TimPansino force-pushed the fix-linter-ruff branch 4 times, most recently from beed847 to edbbf78 Compare April 22, 2025 23:18
@mergify mergify bot added tests-failing Tests failing in CI. and removed tests-failing Tests failing in CI. labels Apr 22, 2025
@mergify mergify bot added tests-failing Tests failing in CI. and removed tests-failing Tests failing in CI. labels Apr 28, 2025
@mergify mergify bot added tests-failing Tests failing in CI. and removed tests-failing Tests failing in CI. labels May 12, 2025
@mergify mergify bot added tests-failing Tests failing in CI. and removed tests-failing Tests failing in CI. labels May 13, 2025
@mergify mergify bot added the merge-conflicts Merge conflicts detected. label May 23, 2025
@mergify mergify bot added tests-failing Tests failing in CI. and removed tests-failing Tests failing in CI. labels Aug 4, 2025
@mergify mergify bot removed the tests-failing Tests failing in CI. label Aug 11, 2025
umaannamalai
umaannamalai previously approved these changes Aug 21, 2025
@mergify mergify bot added the merge-conflicts Merge conflicts detected. label Aug 21, 2025
@TimPansino TimPansino enabled auto-merge (squash) August 21, 2025 21:03
@mergify mergify bot removed the merge-conflicts Merge conflicts detected. label Aug 21, 2025
@mergify mergify bot added the tests-failing Tests failing in CI. label Aug 21, 2025
@TimPansino TimPansino merged commit 18ba348 into main Aug 25, 2025
105 of 110 checks passed
@TimPansino TimPansino deleted the fix-linter-ruff branch August 25, 2025 22:32
@mergify mergify bot removed the tests-failing Tests failing in CI. label Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants