-
Notifications
You must be signed in to change notification settings - Fork 131
Add nginx one console connection telemetry field #3717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Do we add release notes for adding telemetry fields since its user information? |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3717 +/- ##
==========================================
- Coverage 86.95% 86.91% -0.04%
==========================================
Files 128 128
Lines 15962 15965 +3
Branches 62 62
==========================================
- Hits 13879 13876 -3
- Misses 1917 1922 +5
- Partials 166 167 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@salonichf5 I don't think we have in the past, though we do update our documentation page that talks about this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you already done the testing on the xcdf side and updated the schema on that side?
no, waiting on databricks to start working for me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving for now, though probably shouldnt be merged until xcdf testing is completed, also should update https://github.com/nginx/documentation/blob/main/content/ngf/overview/product-telemetry.md
Docs PR - nginx/documentation#944 |
37a5ec8
to
92e640b
Compare
verified that the field shows up as expected on Dev and prod endpoints. |
Problem: We want to know how many clusters are connected to NGINX One console. Solution: Reports product telemetry to report if cluster is connected to NGINX One console
Problem: We want to know how many clusters are connected to NGINX One console. Solution: Reports product telemetry to report if cluster is connected to NGINX One console
Add nginx one console connection telemetry field (#3717) Problem: We want to know how many clusters are connected to NGINX One console. Solution: Reports product telemetry to report if cluster is connected to NGINX One console
Proposed changes
Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:
Problem: We want to know how many clusters are connected to NGINX One console.
Solution: Reports product telemetry to report if cluster is connected to NGINX One console
Testing: Unit tests, functional tests
Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.
Closes #3119
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.