samples: net: Cherry-pick Wi-Fi snippet && fixes #2072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
NordicBuilder
requested review from
57300,
SeppoTakalo,
glarsennordic,
jukkar,
krish2718,
nordic-krch,
nordicjm and
tejlmand
rlubos
force-pushed
the
ncs/cherry-pick-wi-fi-sample-snippet
branch
from
94d4de4 to
a6d824d
Compare
glarsennordic
approved these changes
Oct 7, 2024
Contributor
That is the correct way to do it. The driver in upstream is most likely enabled because it has a dts entry and the sample enables NETWORKING, there is no devicetree processing in sysbuild and because partition manager runs from a sysbuild context, it needs to be in control of wifi enablement (though maybe once PM goes it can be moved to application) |
rlubos
force-pushed
the
ncs/cherry-pick-wi-fi-sample-snippet
branch
2 times, most recently
from
2b46a8e to
d048063
Compare
jukkar
approved these changes
Oct 10, 2024
krish2718
reviewed
Oct 11, 2024
samples/net/wifi/Kconfig.sysbuild
Outdated
|
|
||
| config WIFI_NRF70 | ||
| default y if BOARD_NRF7002DK_NRF5340_CPUAPP || \ | ||
| BOARD_NRF7002DK_NRF5340_CPUAPP_NS |
Contributor
There was a problem hiding this comment.
We also need to do this for all Wi-Fi shields, else those combinations will fail :-(.
Contributor
Author
There was a problem hiding this comment.
For shields, do we have a Kconfig symbol we can depend on here?
Contributor
There was a problem hiding this comment.
We have a Kconfig symbol but it's not working for sysbuild for some reason, so, I have directly updated sample.yaml to get twister green.
rlubos
force-pushed
the
ncs/cherry-pick-wi-fi-sample-snippet
branch
2 times, most recently
from
6ef1110 to
494a43e
Compare
…N in CMake Evaluate CONFIG_LINKER_ITERABLE_SUBALIGN in CMake instead of in the linker script. It cannot be assumed that a linker generator implementation is pre-processed and therefore Kconfig settings cannot be used in those but must be evaluated in CMake. Signed-off-by: Torsten Rasmussen <[email protected]> (cherry picked from commit 205691e) Signed-off-by: Robert Lubos <[email protected]>
native_posix is now deprecated. Building these samples in both native_sim and native_posix does not improve coverage for these samples but doubles CI time. As anyhow native_posix will be removed all together in 2 releases, let's remove it already for this sample. Signed-off-by: Alberto Escolar Piedras <[email protected]> (cherry picked from commit d9aae58) Signed-off-by: Robert Lubos <[email protected]>
Introduce a snippet for configuring IPv4 over Wi-Fi support in networking samples. Signed-off-by: Robert Lubos <[email protected]> (cherry picked from commit 0fdfad8)
… samples Make use of wifi-ipv4 snippet in several networking samples. Signed-off-by: Robert Lubos <[email protected]> (cherry picked from commit fd2fa54)
… disabled Building the sample with IPv4 only gives the following warning: tcp.c:99:37: warning: array subscript 'struct sockaddr[0]' is partly outside array bounds of 'struct sockaddr_in[1]' [-Warray-bounds] data->tcp.sock = socket(addr->sa_family, SOCK_STREAM, IPPROTO_TCP); This doesn't really seem like a valid one, but to get rid of it workaround by specifying address family explicitly. Signed-off-by: Robert Lubos <[email protected]> (cherry picked from commit 0623b23)
…que' error Refactor the code to comply with: Violation to rule 5.7 (Tag name should be unique) tag: data Rename the structure to avoid excessive refactoring. Signed-off-by: Robert Lubos <[email protected]> (cherry picked from commit 7b854d8)
In case CONFIG_DNS_RESOLVER_MAX_SERVERS is larger than the actual number of DNS servers configured, some server entries may be left uninitialized. The dispatcher needs to take this into account, otherwise it may cause memory corruptions. Signed-off-by: Robert Lubos <[email protected]> (cherry picked from commit 5c6b003)
The sample uses net_config library, so there's no need for the sample to configure unicast IP addresses manually. Signed-off-by: Robert Lubos <[email protected]> (cherry picked from commit 7d91281)
Building the net logger backend with IPv4 only gives the following warning: log_backend_net.c:116:31: warning: array subscript 'struct sockaddr[0]' is partly outside array bounds of 'struct sockaddr_in[1]' [-Warray-bounds] local_addr->sa_family = server_addr.sa_family; hence assign the address family directly to sockaddr_in/6 structs. Signed-off-by: Robert Lubos <[email protected]> (cherry picked from commit c6cc87c)
This reverts commit c8082c5. Wi-Fi support for networking sample was added directly upstream. Signed-off-by: Robert Lubos <[email protected]>
…nRF700x" This reverts commit 13fd467. Wi-Fi support was added directly upstream. Signed-off-by: Robert Lubos <[email protected]>
Add support for nRF91x by providing overlay configuration file. Signed-off-by: Juha Ylinen <[email protected]> Signed-off-by: Robert Lubos <[email protected]> (cherry picked from commit d96769f) (cherry picked from commit 13fd467)
rlubos
force-pushed
the
ncs/cherry-pick-wi-fi-sample-snippet
branch
from
494a43e to
5872446
Compare
Make sure Wi-Fi driver is enabled in networking samples supporting Wi-Fi when sysbuild is used. Signed-off-by: Robert Lubos <[email protected]>
rlubos
force-pushed
the
ncs/cherry-pick-wi-fi-sample-snippet
branch
from
5872446 to
6976765
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
manifest-pr-skip