Open
Conversation
sea-bass
force-pushed
the
check-bindings-diff
branch
from
b31e751 to
12adde6
Compare
sea-bass
force-pushed
the
check-bindings-diff
branch
from
6478850 to
84821ef
Compare
sea-bass
changed the title
eholum
approved these changes
Mar 16, 2026
Collaborator
eholum
left a comment
eholum
left a comment
There was a problem hiding this comment.
we use a consistent version of nanobind managed by the pixi lockfile. Worth it?
Hard yes.
| # Create a workspace and copy in the source code. | ||
| RUN mkdir -p /roboplan_ws | ||
| RUN mkdir -p /roboplan_ws \ | ||
| && git config --global --add safe.directory /roboplan_ws |
Collaborator
There was a problem hiding this comment.
Is there something running in the images that needs this? If not maybe we should just add a .git/* to the Dockerignore so that it isn't copied into the workspace in the container?
Collaborator
Author
There was a problem hiding this comment.
That's a much better option.
Basically I went through a few iterations on where to run this CI check, and without these Dockerfile changes running git commands in the containers failed.
But since we're doing it in the Pixi job now...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a check to CI builds to verify nanobind generated stub (
.pyi) files.The check happens with pixi, because all the other CI jobs use Docker and we are not mounting any volumes etc., so checking git diffs doesn't work with how things are now.
Because of this, we now should use
pixi run -e ci install_allto ensure we don't use symlink install and we use a consistent version ofnanobindmanaged by thepixilockfile. Worth it? I think overall it's a positive.Sorry for the lockfile changes.
Success version:
Failing version:
