Push completion legacy state if lift is already on the level#510
Open
aaronchongth wants to merge 1 commit intomainfrom
Open
Push completion legacy state if lift is already on the level#510aaronchongth wants to merge 1 commit intomainfrom
aaronchongth wants to merge 1 commit intomainfrom
Conversation
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix
Fixed bug
Fixes open-rmf/rmf_demos#346
If the RTF is fast enough, this is able to be resolved by the usual lift state subscription observer, but with a normal RTF it can get skipped as the lift states don't come in fast enough, therefore leaving the event on Standby. Which causes the below event states, note that the stale Standby event causes the upstream events to also be on Standby even though subsequent events have already been completed successfully
Fix applied
Added the missing push of completion legacy status when the lift is already on the same level.
Screencast.From.2026-02-25.14-04-14.mp4
GenAI Use
We follow OSRA's policy on GenAI tools
Generated-by: