Skip to content

Push completion legacy state if lift is already on the level#510

Open
aaronchongth wants to merge 1 commit intomainfrom
fix/demos-346
Open

Push completion legacy state if lift is already on the level#510
aaronchongth wants to merge 1 commit intomainfrom
fix/demos-346

Conversation

@aaronchongth
Copy link
Member

@aaronchongth aaronchongth commented Feb 25, 2026

Bug fix

Fixed bug

Fixes open-rmf/rmf_demos#346

If the RTF is fast enough, this is able to be resolved by the usual lift state subscription observer, but with a normal RTF it can get skipped as the lift states don't come in fast enough, therefore leaving the event on Standby. Which causes the below event states, note that the stale Standby event causes the upstream events to also be on Standby even though subsequent events have already been completed successfully

                     "11": {
                        "deps": [],
                        "detail": "",
                        "id": 11,
                        "name": "Requesting lift [Lift2] to [L1]",
                        "status": "standby"
                    },
                    "12": {
                        "deps": [],
                        "detail": "",
                        "id": 12,
                        "name": "Move to [graph-wp:17] < 16.9841 -24.2211  -1.5817> through 2 points",
                        "status": "completed"
                    },
                    "13": {
                        "deps": [],
                        "detail": "",
                        "id": 13,
                        "name": "Requesting lift [Lift2] to [L2]",
                        "status": "completed"
                    },
                    "14": {
                        "deps": [],
                        "detail": "",
                        "id": 14,
                        "name": "Move to [graph-wp:24] < 17.0699 -21.6342 -1.60394> through 2 points",
                        "status": "completed"
                    },
                    "15": {
                        "deps": [],
                        "detail": "",
                        "id": 15,
                        "name": "End session with lift [Lift2]",
                        "status": "completed"
                    },
                     ...,
                     "9": {
                        "deps": [
                            11,
                            12,
                            13,
                            14,
                            15
                        ],
                        "detail": "",
                        "id": 9,
                        "name": "Take [lift:Lift2] to [floor:L2]",
                        "status": "standby"
                    },
                   ....

Fix applied

Added the missing push of completion legacy status when the lift is already on the same level.

Screencast.From.2026-02-25.14-04-14.mp4

GenAI Use

We follow OSRA's policy on GenAI tools

  • I used a GenAI tool in this PR.
  • I did not use GenAI

Generated-by:

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

[Bug]: Task Status switches from Underway to Standby when entering lift and never recovers, despite task completing successfully.

3 participants