-
Notifications
You must be signed in to change notification settings - Fork 163
declarative config: add declaravite config bridge, gcp auth, span stacktrace #2020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔧 The result from spotlessApply was committed to the PR branch. |
...uth-extension/src/main/java/io/opentelemetry/contrib/gcp/auth/GcpAuthCustomizerProvider.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
notes from discussion with @jaydeluca
* string_key: value | ||
* </pre> | ||
*/ | ||
final class DeclarativeConfigPropertiesBridge implements ConfigProperties { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the bridge is also part of open-telemetry/opentelemetry-java-instrumentation#14184 - once it's reviewed there it will be updated here
but that can also be done after this PR is merged
...tacktrace/src/main/java/io/opentelemetry/contrib/stacktrace/StackTraceComponentProvider.java
Show resolved
Hide resolved
...tacktrace/src/main/java/io/opentelemetry/contrib/stacktrace/StackTraceComponentProvider.java
Outdated
Show resolved
Hide resolved
This reverts commit 2e2bb79.
…auth/GcpAuthAutoConfigurationCustomizerProvider.java Co-authored-by: Pranav Sharma <[email protected]>
…auth/GcpAuthCustomizerProvider.java Co-authored-by: Pranav Sharma <[email protected]>
🔧 The result from spotlessApply was committed to the PR branch. |
Blocked by open-telemetry/opentelemetry-configuration#257 for GCP auth
Fixes #2012
Fixes #2028