Skip to content

add declarative config for baggage #2031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 9, 2025
Merged

add declarative config for baggage #2031

merged 8 commits into from
Sep 9, 2025

Conversation

@zeitlinger
Copy link
Member

@zeitlinger zeitlinger commented Jul 16, 2025 •
edited
Loading

Fixes #2013

@zeitlinger zeitlinger force-pushed the baggage-declarative-config branch from f89cb52 to 507cef9 Compare August 15, 2025 11:57
@github-actions github-actions bot requested a review from MikeGoldsmith August 15, 2025 11:57
@zeitlinger zeitlinger marked this pull request as ready for review August 15, 2025 12:57
@zeitlinger zeitlinger requested a review from a team as a code owner August 15, 2025 12:57
@zeitlinger
Copy link
Member Author

zeitlinger commented Aug 18, 2025

@jaydeluca please have a look

trask
trask reviewed Aug 18, 2025
View reviewed changes
@trask trask added this to the v1.49.0 milestone Aug 19, 2025
@zeitlinger zeitlinger mentioned this pull request Aug 20, 2025
Open
@trask trask added this pull request to the merge queue Aug 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 20, 2025
@trask trask added this pull request to the merge queue Aug 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Aug 20, 2025
@laurit laurit mentioned this pull request Aug 21, 2025
Closed
@zeitlinger zeitlinger force-pushed the baggage-declarative-config branch from 0072c76 to e4c885f Compare August 21, 2025 13:51
@trask
Copy link
Member

trask commented Aug 22, 2025

@zeitlinger 3 tests are still failing even after rerunning them, can you check? worried to merge and possibly make our flaky test situation worse

@zeitlinger
Copy link
Member Author

zeitlinger commented Aug 22, 2025

@zeitlinger 3 tests are still failing even after rerunning them, can you check? worried to merge and possibly make our flaky test situation worse

should be addressed with #2152

@trask trask removed this from the v1.49.0 milestone Aug 22, 2025
MikeGoldsmith
MikeGoldsmith approved these changes Aug 26, 2025
View reviewed changes
Copy link
Member

@MikeGoldsmith MikeGoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @zeitlinger!

@github-actions github-actions bot requested a review from MikeGoldsmith August 26, 2025 20:41
@zeitlinger zeitlinger force-pushed the baggage-declarative-config branch from c27c16f to 00c7b28 Compare September 3, 2025 12:24
@zeitlinger zeitlinger mentioned this pull request Sep 4, 2025
Merged
@zeitlinger zeitlinger force-pushed the baggage-declarative-config branch from bfd00b9 to df6378e Compare September 5, 2025 16:37
@trask
Copy link
Member

trask commented Sep 8, 2025

@zeitlinger do you think there are any updates that make sense to the READMEs for declarative config support on these PRs?

@zeitlinger zeitlinger force-pushed the baggage-declarative-config branch from df6378e to a840b47 Compare September 9, 2025 11:16
@otelbot-java-contrib
Copy link
Contributor

otelbot-java-contrib bot commented Sep 9, 2025

🔧 The result from spotlessApply was committed to the PR branch.

This was referenced Sep 9, 2025
Open
Draft
@zeitlinger
Copy link
Member Author

zeitlinger commented Sep 9, 2025

@zeitlinger do you think there are any updates that make sense to the READMEs for declarative config support on these PRs?

done for this one - and later in the others once the config bridge is available

@trask trask added this pull request to the merge queue Sep 9, 2025
Merged via the queue into open-telemetry:main with commit bb5449f Sep 9, 2025
25 checks passed
@zeitlinger zeitlinger deleted the baggage-declarative-config branch September 9, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkwatson jkwatson jkwatson left review comments

@trask trask trask approved these changes

@MikeGoldsmith MikeGoldsmith Awaiting requested review from MikeGoldsmith

Assignees

@zeitlinger zeitlinger

@MikeGoldsmith MikeGoldsmith

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

declarative config: baggage processor

4 participants

@zeitlinger @trask @jkwatson @MikeGoldsmith