Skip to content

Conversation

@jaydeluca
Copy link
Member

No description provided.

@jaydeluca jaydeluca requested a review from a team as a code owner August 25, 2025 10:51
type: STRING
- name: aws-lambda-events-3.11
description: |
Provides full instrumentation of the Lambda library, including standard and custom event types, from `aws-lambda-java-events` 3.11+.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is copied form the old instrumentation which in turn copies from https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation/aws-lambda/README.md Imo the meaning for full instrumentation is lost here without knowing that this instrumentation builds on top of aws-lambda-core-1.0 that provides lightweight instrumentation

- name: aws-lambda-core-1.0
description: |
Provides lightweight instrumentation of the Lambda core library, supporting all versions. It generates FaaS SERVER spans with the `faas.invocation_id` attribute. Use this package if you only use `RequestStreamHandler` or know you don't use any event classes from `aws-lambda-java-events`. This also includes when you are using `aws-serverless-java-container` to run e.g., a Spring Boot application on Lambda.
For custom wrappers when using library instrumentation, you can configure the `OTEL_INSTRUMENTATION_AWS_LAMBDA_HANDLER` env property to your lambda handler method in following format `package.ClassName::methodName` and use one of wrappers as your lambda `Handler`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd replace env property with environment variable

- name: aws-lambda-events-2.2
description: |
Provides full instrumentation of the Lambda library, including standard and custom event types, from `aws-lambda-java-events` 2.2+.
This version of the library instrumentation is deprecated, please use the aws-lambda-events-3.11 library instrumentation instead. This instrumentation builds on top of the lightweight `aws-lambda-core-1.0` instrumentation, expanding support to cover the Lambda library, including standard and custom event types.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove lightweight

@laurit laurit merged commit f5256cf into open-telemetry:main Aug 28, 2025
89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants