Skip to content

Conversation

lukeina2z
Copy link
Contributor

This PR adds the aws.secretsmanager.secret.arn semantic convention attribute for the following AWS resources:

AWS Secrets Manager SDK

The Secret ARN is extracted from both request and response objects, and this behavior is covered by unit tests.

Tests Run:
npm run compile
npm run lint
npm run test

All newly added tests pass, and no regressions were found.

Backward Compatibility:
This change is fully backward compatible. It introduces instrumentation for an additional AWS resource without modifying existing behavior in the auto-instrumentation library.

@lukeina2z lukeina2z requested a review from a team as a code owner August 5, 2025 21:28
@github-actions github-actions bot requested review from blumamir, jj22ee and trivikr August 5, 2025 21:28
@lukeina2z lukeina2z changed the title Add Semantic Convention Support for Amazon Secrets Manager Attributes feat(instrumentation-aws-sdk): Add Semantic Convention Support for Amazon Secrets Manager Attributes Aug 5, 2025
Copy link

codecov bot commented Aug 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.87%. Comparing base (e6c29be) to head (9e75886).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2971      +/-   ##
==========================================
+ Coverage   89.79%   89.87%   +0.08%     
==========================================
  Files         188      189       +1     
  Lines        9295     9314      +19     
  Branches     1907     1911       +4     
==========================================
+ Hits         8346     8371      +25     
+ Misses        949      943       -6     
Files with missing lines Coverage Δ
packages/instrumentation-aws-sdk/src/semconv.ts 100.00% <100.00%> (ø)
...ntation-aws-sdk/src/services/ServicesExtensions.ts 97.05% <100.00%> (+0.18%) ⬆️
...rumentation-aws-sdk/src/services/secretsmanager.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lukeina2z lukeina2z force-pushed the sm-pr-foo branch 2 times, most recently from feb7bcc to 7d36434 Compare August 8, 2025 19:09
@pichlermarc pichlermarc added the has:owner-approval Approved by Component Owner label Aug 13, 2025
This PR adds the aws.secretsmanager.secret.arn semantic convention attribute for the following AWS resources:

AWS Secrets Manager SDK

The Secret ARN is extracted from both request and response objects, and this behavior is covered by unit tests.

Tests Run:
npm run compile
npm run lint
npm run test

All newly added tests pass, and no regressions were found.

Backward Compatibility:
This change is fully backward compatible. It introduces instrumentation for an additional AWS resource without modifying existing behavior in the auto-instrumentation library.
@pichlermarc pichlermarc enabled auto-merge (squash) August 20, 2025 14:58
@pichlermarc pichlermarc merged commit 0c59990 into open-telemetry:main Aug 20, 2025
25 checks passed
@dyladan dyladan mentioned this pull request Aug 19, 2025
@lukeina2z lukeina2z deleted the sm-pr-foo branch August 27, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants