-
Notifications
You must be signed in to change notification settings - Fork 596
feat(instrumentation-aws-sdk): Add Semantic Convention Support for Amazon Secrets Manager Attributes #2971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2971 +/- ##
==========================================
+ Coverage 89.79% 89.87% +0.08%
==========================================
Files 188 189 +1
Lines 9295 9314 +19
Branches 1907 1911 +4
==========================================
+ Hits 8346 8371 +25
+ Misses 949 943 -6
🚀 New features to boost your workflow:
|
jj22ee
reviewed
Aug 8, 2025
feb7bcc
to
7d36434
Compare
jj22ee
approved these changes
Aug 9, 2025
trivikr
approved these changes
Aug 11, 2025
pichlermarc
approved these changes
Aug 13, 2025
trentm
reviewed
Aug 13, 2025
This PR adds the aws.secretsmanager.secret.arn semantic convention attribute for the following AWS resources: AWS Secrets Manager SDK The Secret ARN is extracted from both request and response objects, and this behavior is covered by unit tests. Tests Run: npm run compile npm run lint npm run test All newly added tests pass, and no regressions were found. Backward Compatibility: This change is fully backward compatible. It introduces instrumentation for an additional AWS resource without modifying existing behavior in the auto-instrumentation library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the aws.secretsmanager.secret.arn semantic convention attribute for the following AWS resources:
AWS Secrets Manager SDK
The Secret ARN is extracted from both request and response objects, and this behavior is covered by unit tests.
Tests Run:
npm run compile
npm run lint
npm run test
All newly added tests pass, and no regressions were found.
Backward Compatibility:
This change is fully backward compatible. It introduces instrumentation for an additional AWS resource without modifying existing behavior in the auto-instrumentation library.