Skip to content

Conversation

@cijothomas
Copy link
Member

Don't think public was required, and this should be transparent to users anyway...
https://github.com/open-telemetry/opentelemetry-rust/pull/2837/files#r2008002156

@cijothomas cijothomas requested a review from a team as a code owner March 21, 2025 18:40
@cijothomas cijothomas requested review from Copilot and gruebel March 21, 2025 18:40
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR changes the visibility of the fields in KeyValueMetadata from public to crate-level, ensuring that internal implementation details remain encapsulated and transparent to users.

  • Changed KeyValueMetadata field visibility in opentelemetry/src/baggage.rs
  • Updated the CHANGELOG.md to document the new encapsulation

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
opentelemetry/src/baggage.rs Changed field visibility from pub to pub(crate) for encapsulation
opentelemetry/CHANGELOG.md Updated changelog entry to reflect the new visibility of KeyValueMetadata

Copy link
Member

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.9%. Comparing base (3e77a22) to head (ce94863).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2843   +/-   ##
=====================================
  Coverage   80.9%   80.9%           
=====================================
  Files        124     124           
  Lines      23726   23726           
=====================================
  Hits       19200   19200           
  Misses      4526    4526           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cijothomas cijothomas merged commit 1ecd1a8 into open-telemetry:main Mar 21, 2025
23 checks passed
@cijothomas cijothomas deleted the cijothomas/baggage-nits branch March 21, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants