Skip to content

fix: KeyValueMetadata to not expose its fields public #2843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cijothomas merged 2 commits into from
Mar 21, 2025
Merged

fix: KeyValueMetadata to not expose its fields public #2843

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
daec0df
fix: KeyValueMetadata to not expose its fields public
cijothomas Mar 21, 2025
ce94863
Merge branch 'main' into cijothomas/baggage-nits
cijothomas Mar 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions opentelemetry/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
- `Baggage` can't be retrieved from the `Context` directly anymore and needs to be accessed via `context.baggage()`
- `with_baggage()` and `current_with_baggage()` override any existing `Baggage` in the `Context`
- `Baggage` keys can't be empty and only allow ASCII visual chars, except `"(),/:;<=>?@[\]{}` (see [RFC7230, Section 3.2.6](https://datatracker.ietf.org/doc/html/rfc7230#section-3.2.6))
- `KeyValueMetadata` does not publicly expose its fields. This should be transparent change to the users.
- Changed `Context` to use a stack to properly handle out of order dropping of `ContextGuard`. This imposes a limit of `65535` nested contexts on a single thread. See #[2378](https://github.com/open-telemetry/opentelemetry-rust/pull/2284) and #[1887](https://github.com/open-telemetry/opentelemetry-rust/issues/1887).
- Added additional `name: Option<&str>` parameter to the `event_enabled` method
on the `Logger` trait. This allows implementations (SDK, processor, exporters)
Expand Down
6 changes: 3 additions & 3 deletions opentelemetry/src/baggage.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,11 +458,11 @@ impl fmt::Display for BaggageMetadata {
#[derive(Clone, Debug, PartialEq)]
pub struct KeyValueMetadata {
/// Dimension or event key
pub key: Key,
pub(crate) key: Key,
/// Dimension or event value
pub value: StringValue,
pub(crate) value: StringValue,
/// Metadata associate with this key value pair
pub metadata: BaggageMetadata,
pub(crate) metadata: BaggageMetadata,
}

impl KeyValueMetadata {
Expand Down