-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Fixes several links from the documentation site to different javascript instrumentation packages #7276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes several links from the documentation site to different javascript instrumentation packages #7276
Conversation
Signed-off-by: Kurt King <[email protected]>
svrnm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! LGTM
That would be me missing this. The changes in directories in opentelemetry-js-contrib.git was done recently in open-telemetry/opentelemetry-js-contrib#2928 Thanks for doing this update! |
|
/fix:all |
|
✅ |
|
There are still a number of hits for the old dirs. For example: I am happy to follow-up with a second PR to catch those if you like, or I can post all of the hits I see here. @svrnm Some of the hits for the now obsolete dirs are in |
That would be appreciated
let's leave them where they are right now, it's a long term item on our todo list to get the refcache put into action, i.e. have items removed, have them checked regularly, etc. |
Ha, and thank you all for the documentation 💯 |
|
Here are 50 other hits: https://gist.github.com/trentm/edd6a23e7dc888e736a84ac51037a04b If you merge this PR as is, I will follow-up with one that updates those other references. |
I don't mind, but it will be much later today. I am heads down on some deliverables at work. |
|
thanks @kurtaking! we have one more PR for this: #7285 |
|
Thank you for your contribution @kurtaking! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. |
…pt instrumentation packages (open-telemetry#7276) Signed-off-by: Kurt King <[email protected]> Co-authored-by: opentelemetrybot <[email protected]> Co-authored-by: Severin Neumann <[email protected]>
This PR fixes several broken links from the documentation site to different instrumentation packages. I'm assuming this was missed during a migration of packages from
plugins/node->packages.Example:
Looking at this documentation, clicking the second link takes you to a 404 page.