chore: Use shared Task definitions #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moelsayed
force-pushed
the
use_tasks
branch
2 times, most recently
from
6e7d009 to
e380dca
Compare
Closed
3 tasks
Diaphteiros
requested changes
Apr 30, 2025
Taskfile.yaml
Outdated
| CODE_DIRS: '{{.ROOT_DIR}}/cmd/... {{.ROOT_DIR}}/internal/... {{.ROOT_DIR}}/test/... {{.ROOT_DIR}}/api/core/v1alpha1/...' | ||
| COMPONENTS: 'project-workspace-operator' | ||
| REPO_URL: 'https://github.com/openmcp-project/project-workspace-operator' | ||
| GENERATE_DOCS_INDEX: "true" |
There was a problem hiding this comment.
We should either remove this, or set it up correctly, otherwise it just generates an empty index file.
See https://github.com/openmcp-project/build?tab=readme-ov-file#documentation-index-generation for a short documentation on the feature and https://github.com/openmcp-project/mcp-operator/blob/main/docs/controllers/.docnames for an example of one of the mentioned metadata files.
docs/README.md
Outdated
There was a problem hiding this comment.
We should either remove the documentation index generation and this file or set it up to contain actual content, see above.
Diaphteiros
requested changes
Apr 30, 2025
Co-authored-by: Johannes Aubart <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This PR changes the artifact paths from
ghcr.io/openmcp-project/github.com/openmcp-project/...toghcr.io/openmcp-project/....Release note: