Extract some workflow steps to Github and exclude from Jenkins runner#20946
Extract some workflow steps to Github and exclude from Jenkins runner#20946cwperks wants to merge 4 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Craig Perkins <cwperx@amazon.com>
PR Code Analyzer ❗AI-powered 'Code-Diff-Analyzer' found issues on commit c89efc5.
The table above displays the top 10 most important findings. Pull Requests Author(s): Please update your Pull Request according to the report above. Repository Maintainer(s): You can Thanks. |
Signed-off-by: Craig Perkins <cwperx@amazon.com>
PR Reviewer Guide 🔍(Review updated until commit 98a0fe0)Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Latest suggestions up to 98a0fe0 Explore these optional code suggestions:
Previous suggestionsSuggestions up to commit e8d1eb1
Suggestions up to commit 6df7c9b
|
| final MsalServiceException e = expectThrows(MsalServiceException.class, () -> client1.getAccountInfo()); | ||
| assertThat(e.getMessage(), containsString("[Managed Identity] MSI returned 401")); | ||
| // Managed identity path builds an HTTPS endpoint URL, not a connection string with embedded key | ||
| assertThat(client1.getAccountUrl(), equalTo("https://myaccount1.blob.core.windows.net")); |
There was a problem hiding this comment.
Fixes the error seen here: https://github.com/opensearch-project/OpenSearch/actions/runs/23354788293/job/67942749650
Suite: Test class org.opensearch.repositories.azure.AzureStorageServiceTests
2> REPRODUCE WITH: ./gradlew ':plugins:repository-azure:test' --tests 'org.opensearch.repositories.azure.AzureStorageServiceTests.testClientUsingManagedIdentity' -Dtests.seed=F2A1209AD7C630AC -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=cgg-UG -Dtests.timezone=America/Fortaleza -Druntime.java=25
2> java.lang.AssertionError:
Expected: a string containing "[Managed Identity] MSI returned 401"
but: was "[Managed Identity] Authentication unavailable. The requested identity has not been assigned to this resource.Status: 400Content:{"error":"invalid_request","error_description":"Identity not found"}Headers:Server[IMDS/150.870.65.1854]Content-Length[68]x-ms-request-id[23532fc5-479b-4cb6-9835-9485a51600a3]Date[Fri, 20 Mar 2026 17:35:08 GMT]Content-Type[application/json; charset=utf-8] [Managed Identity] Error Code: invalid_request Error Message: Identity not found"
Signed-off-by: Craig Perkins <cwperx@amazon.com>
|
Persistent review updated to latest commit e8d1eb1 |
|
❌ Gradle check result for e8d1eb1: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Craig Perkins <cwperx@amazon.com>
|
Persistent review updated to latest commit 98a0fe0 |
|
❌ Gradle check result for 98a0fe0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Description
This PR is part of a series of 3:
Currently trying to experiment with ways to increase the build's success percentage. See the daily report here.
The new workflow is this PR extracts the gradle check for the repository-gcs and repository-azure plugins to Github rather then Jenkins. The idea is that these are 1) run in parallel to speed up the core gradle check on Jenkins and 2) eventually we can get to the point where these only run when the code or dependencies have changed instead of on every pr.
If this works and has support then I will also open a pr on opensearch-build to exclude these checks from the main gradle check. i.e.
-x :plugins:repository-azure:check -x :plugins:repository-gcs:checkRelated Issues
Related to #19378
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.