Skip to content

[FEATURE REQUEST] Set space cells in horizontal with menu#4665

Merged
joragua merged 13 commits intomasterfrom
feature/spaces_in_horizontal_with_menu
Aug 27, 2025
Merged

[FEATURE REQUEST] Set space cells in horizontal with menu#4665
joragua merged 13 commits intomasterfrom
feature/spaces_in_horizontal_with_menu

Conversation

@joragua
Copy link
Collaborator

@joragua joragua commented Aug 25, 2025

Related Issues

App: #4604

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

Checklist: #4665 (comment)

Reports:

@joragua joragua self-assigned this Aug 25, 2025
@joragua joragua linked an issue Aug 25, 2025 that may be closed by this pull request
11 tasks
@joragua joragua force-pushed the feature/spaces_in_horizontal_with_menu branch 2 times, most recently from 819e4e0 to f0ee0b2 Compare August 25, 2025 12:49
@joragua joragua force-pushed the feature/spaces_in_horizontal_with_menu branch 2 times, most recently from 4cb1270 to 596d782 Compare August 26, 2025 09:14
@joragua joragua marked this pull request as ready for review August 26, 2025 09:28
@joragua joragua requested a review from jesmrec August 26, 2025 09:28
@joragua joragua force-pushed the feature/spaces_in_horizontal_with_menu branch from e7f8921 to 04b055e Compare August 26, 2025 12:01
@joragua joragua force-pushed the feature/spaces_in_horizontal_with_menu branch from f0573bd to 3cc0159 Compare August 26, 2025 12:06
@joragua joragua requested a review from jesmrec August 26, 2025 12:14
@joragua joragua requested a review from jesmrec August 26, 2025 12:36
@jesmrec
Copy link
Collaborator

jesmrec commented Aug 26, 2025

CR-approved!! let's go for the QA

@jesmrec
Copy link
Collaborator

jesmrec commented Aug 26, 2025

QA checks

View

  • Small screen (~5inches)
    • No spaces (portrait/landscape)
    • 1 space (portrait/landscape)
    • 2 spaces (portrait/landscape)
    • > 2 spaces (portrait/landscape)
    • Filtering
  • Medium screen (~6inches)
    • No spaces (portrait/landscape)
    • 1 space (portrait/landscape)
    • 2 spaces (portrait/landscape)
    • > 2 spaces (portrait/landscape)
    • Filtering
  • Big screen (> 7inches)
    • No spaces (portrait/landscape)
    • 1 space (portrait/landscape)
    • 2 spaces (portrait/landscape)
    • > 2 spaces (portrait/landscape)
    • Filtering

Bottom Menu

  • Small screen (~5inches)

    • Icon (portrait/landscape)
    • Name (portrait/landscape)
    • Size (portrait/landscape)
    • Close (portrait/landscape)
  • Medium screen (~6inches)

    • Icon (portrait/landscape)
    • Name (portrait/landscape)
    • Size (portrait/landscape)
    • Close (portrait/landscape)
  • Big screen (> 7inches)

    • Icon (portrait/landscape)
    • Name (portrait/landscape)
    • Size (portrait/landscape)
    • Close (portrait/landscape)
  • Kiteworks server

  • Accessibility

@jesmrec
Copy link
Collaborator

jesmrec commented Aug 26, 2025

(1) [FIXED]

  1. Open an account with 6-8 spaces attached
  2. Open the spaces view
  3. Set landscape and scroll down

Current:

Spaces grid is misplaced

Screenshot 2025-08-26 at 18 21 00 Screenshot 2025-08-26 at 18 21 31

Expected:

Everything alligned correctly

Xiaomi Redmi 13 Android 15
Pixel 7, Android 16

79183af

@joragua
Copy link
Collaborator Author

joragua commented Aug 27, 2025

(1) should be fixed with the last commit @jesmrec

@jesmrec
Copy link
Collaborator

jesmrec commented Aug 27, 2025

(1) fixed

@jesmrec
Copy link
Collaborator

jesmrec commented Aug 27, 2025

(2) [FIXED]

About accessibility (talkback)

When selecting an space cell, the dictation is always:

Button
Space image
Space name
Space subtitle
Row x (the number of the item)

name or subtitle of the space is never dictated

Xiaomi Redmi 13, Android 15

@joragua joragua force-pushed the feature/spaces_in_horizontal_with_menu branch 2 times, most recently from d8bc67c to 2bb5a0e Compare August 27, 2025 12:45
@joragua joragua force-pushed the feature/spaces_in_horizontal_with_menu branch from 2bb5a0e to d1a3933 Compare August 27, 2025 14:39
@jesmrec
Copy link
Collaborator

jesmrec commented Aug 27, 2025

Approved from my side.

@joragua joragua merged commit b6ef335 into master Aug 27, 2025
10 checks passed
@joragua joragua deleted the feature/spaces_in_horizontal_with_menu branch August 27, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Set space cells in horizontal with menu

3 participants