fix(publish): inverted logic of noninteractive log on failure

[jgranstrom]

The logic condition was inverted for only logging failures from noninteractive publish processes. It was only logging on success if set to log failures. 😃

[jgranstrom]

Build failure seem to be some trivy release gone missing, looks a bit like they have unpublished a bunch of releases 🤷‍♂️

native_engine.IntrinsicError: Client error (404) downloading file trivy_0.57.0_Linux-64bit.tar.gz from https://github.com/aquasecurity/trivy/releases/download/v0.57.0/trivy_0.57.0_Linux-64bit.tar.gz

Edit: Ah I see, their repo was compromised.

[tdyas]

Build failure seem to be some trivy release gone missing, looks a bit like they have unpublished a bunch of releases 🤷‍♂️

native_engine.IntrinsicError: Client error (404) downloading file trivy_0.57.0_Linux-64bit.tar.gz from https://github.com/aquasecurity/trivy/releases/download/v0.57.0/trivy_0.57.0_Linux-64bit.tar.gz

Edit: Ah I see, their repo was compromised.

If you merge in main, then it should be fixed.

[tdyas]

I marked this PR for cherrypicking back to 2.{29,30,31}, which all have the bug.

[WorkerPants]

I tried to automatically cherry-pick this change back to each relevant milestone, so that it is available in those older releases of Pants.

❌ 2.29.x

I was unable to cherry-pick this PR to 2.29.x, likely due to merge-conflicts.

Steps to Cherry-Pick locally

To resolve:

1. (Ensure your git working directory is clean)
2. Run the following script to reproduce the merge-conflicts:

   git fetch https://github.com/pantsbuild/pants main \
     && git fetch https://github.com/pantsbuild/pants 2.29.x \
     && git checkout -b cherry-pick-23154-to-2.29.x FETCH_HEAD \
     && git cherry-pick e774160ec8db96947074f8e037122172465d3b1b

3. Fix the merge conflicts and commit the changes
4. Run build-support/cherry_pick/make_pr.sh "23154" "2.29.x"

Please note that I cannot re-run CI if a job fails. Please work with your PR approver(s) to re-run CI if necessary.

❌ 2.30.x

I was unable to cherry-pick this PR to 2.30.x, likely due to merge-conflicts.

Steps to Cherry-Pick locally

To resolve:

1. (Ensure your git working directory is clean)
2. Run the following script to reproduce the merge-conflicts:

   git fetch https://github.com/pantsbuild/pants main \
     && git fetch https://github.com/pantsbuild/pants 2.30.x \
     && git checkout -b cherry-pick-23154-to-2.30.x FETCH_HEAD \
     && git cherry-pick e774160ec8db96947074f8e037122172465d3b1b

3. Fix the merge conflicts and commit the changes
4. Run build-support/cherry_pick/make_pr.sh "23154" "2.30.x"

Please note that I cannot re-run CI if a job fails. Please work with your PR approver(s) to re-run CI if necessary.

❌ 2.31.x

I was unable to cherry-pick this PR to 2.31.x, likely due to merge-conflicts.

Steps to Cherry-Pick locally

To resolve:

1. (Ensure your git working directory is clean)
2. Run the following script to reproduce the merge-conflicts:

   git fetch https://github.com/pantsbuild/pants main \
     && git fetch https://github.com/pantsbuild/pants 2.31.x \
     && git checkout -b cherry-pick-23154-to-2.31.x FETCH_HEAD \
     && git cherry-pick e774160ec8db96947074f8e037122172465d3b1b

3. Fix the merge conflicts and commit the changes
4. Run build-support/cherry_pick/make_pr.sh "23154" "2.31.x"

Please note that I cannot re-run CI if a job fails. Please work with your PR approver(s) to re-run CI if necessary.

---

When you're done manually cherry-picking, please remove the needs-cherrypick label on this PR.

Thanks again for your contributions!

🤖 Beep Boop here's my run link