Skip to content

Consider assert as side effect #4227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 12, 2025
Merged

Consider assert as side effect #4227

merged 3 commits into from
Sep 12, 2025

Conversation

VincentLanglet
Copy link
Contributor

ondrejmirtes
ondrejmirtes requested changes Sep 7, 2025
View reviewed changes
Copy link
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about CallToConstructorStatementWithoutSideEffectsRule?

@VincentLanglet
Copy link
Contributor Author

What about CallToConstructorStatementWithoutSideEffectsRule?

The issue only appear if you use both @phpstan-pure and @phpstan-assert.
I dunno if it make sens to have a pure constructor.

Anyway it doesn't really cost to add the check, so I updated the PR.

@ondrejmirtes ondrejmirtes merged commit 5c3eed5 into phpstan:2.1.x Sep 12, 2025
450 of 456 checks passed
@ondrejmirtes
Copy link
Member

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ondrejmirtes ondrejmirtes Awaiting requested review from ondrejmirtes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

@phpstan-assert not considered a side effect

2 participants

@VincentLanglet @ondrejmirtes