chore: replace deprecated PingCAP download domains#12583
chore: replace deprecated PingCAP download domains#12583wuhuizuo wants to merge 1 commit intorelease-8.5from
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. |
|
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Code Review
This pull request updates various download URLs across documentation and scripts from 'download.pingcap.org' to 'download.pingcap.com'. The reviewer suggested updating an insecure 'http' URL to 'https' in 'dm/tests/download-compatibility-test-binaries.sh' to ensure secure transport and consistency.
| local download_urls=( | ||
| "${FILE_SERVER_URL}/download/builds/pingcap/tidb/${tidb_sha1}/centos7/tidb-server.tar.gz" | ||
| "http://download.pingcap.org/tidb-enterprise-tools-latest-linux-amd64.tar.gz" | ||
| "http://download.pingcap.com/tidb-enterprise-tools-latest-linux-amd64.tar.gz" |
There was a problem hiding this comment.
Use https instead of http for downloading binaries to ensure a secure connection and maintain consistency with other download URLs in the project. This helps prevent potential man-in-the-middle attacks during the download process.
| "http://download.pingcap.com/tidb-enterprise-tools-latest-linux-amd64.tar.gz" | |
| "https://download.pingcap.com/tidb-enterprise-tools-latest-linux-amd64.tar.gz" |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## release-8.5 #12583 +/- ##
================================================
Coverage ? 53.3830%
================================================
Files ? 1026
Lines ? 137836
Branches ? 0
================================================
Hits ? 73581
Misses ? 58750
Partials ? 5505 🚀 New features to boost your workflow:
|
Summary
download.pingcap.orgreferences withdownload.pingcap.comcharts.pingcap.orgreferences withcharts.pingcap.comwhere presentValidation
git diff --checkdownload.pingcap.org/charts.pingcap.orgreferences in the patched branch