Skip to content

chore: replace deprecated PingCAP download domains #12583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wuhuizuo wants to merge 1 commit into
base: release-8.5
Choose a base branch
from
Open

chore: replace deprecated PingCAP download domains #12583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dm/tests/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

1. The following executables must be copied or generated or linked into these locations.

* `bin/tidb-server` can be downloaded from [tidb-master-linux-amd64](https://download.pingcap.org/tidb-master-linux-amd64.tar.gz) or installed by [tiup](https://github.com/pingcap/tiup), you can use the command `find ~/.tiup -name tidb-server` to locate `tidb-server` binary file and copy it
* `bin/tidb-server` can be downloaded from [tidb-master-linux-amd64](https://download.pingcap.com/tidb-master-linux-amd64.tar.gz) or installed by [tiup](https://github.com/pingcap/tiup), you can use the command `find ~/.tiup -name tidb-server` to locate `tidb-server` binary file and copy it
* `bin/sync_diff_inspector` # generated by `make dm_integration_test_build`
* `bin/minio` can be build from (https://github.com/minio/minio)
* `bin/dm-master.test` # generated by `make dm_integration_test_build`
Expand Down
2 changes: 1 addition & 1 deletion dm/tests/download-compatibility-test-binaries.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ main() {
# Define download URLs
local download_urls=(
"${FILE_SERVER_URL}/download/builds/pingcap/tidb/${tidb_sha1}/centos7/tidb-server.tar.gz"
"http://download.pingcap.org/tidb-enterprise-tools-latest-linux-amd64.tar.gz"
"http://download.pingcap.com/tidb-enterprise-tools-latest-linux-amd64.tar.gz"
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-medium medium

Use https instead of http for downloading binaries to ensure a secure connection and maintain consistency with other download URLs in the project. This helps prevent potential man-in-the-middle attacks during the download process.

Suggested change
"http://download.pingcap.com/tidb-enterprise-tools-latest-linux-amd64.tar.gz"
"https://download.pingcap.com/tidb-enterprise-tools-latest-linux-amd64.tar.gz"

"${GITHUB_RELEASE_URL}/gh-ost-binary-linux-20200828140552.tar.gz"
"${FILE_SERVER_URL}/download/minio.tar.gz"
)
Expand Down
2 changes: 1 addition & 1 deletion dm/tests/tiup/upgrade-from-v1.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ function deploy_v1_by_ansible() {
# step 3
su tidb <<EOF
cd /home/tidb
wget https://download.pingcap.org/dm-ansible-v1.0.7.tar.gz
wget https://download.pingcap.com/dm-ansible-v1.0.7.tar.gz
EOF

# step 4
Expand Down
4 changes: 2 additions & 2 deletions scripts/download-integration-test-binaries.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,10 @@ download_community_binaries() {
local dist="${VERSION}-${OS}-${ARCH}"
local tidb_file_name="tidb-community-server-$dist"
local tidb_tar_name="${tidb_file_name}.tar.gz"
local tidb_url="https://download.pingcap.org/$tidb_tar_name"
local tidb_url="https://download.pingcap.com/$tidb_tar_name"
local toolkit_file_name="tidb-community-toolkit-$dist"
local toolkit_tar_name="${toolkit_file_name}.tar.gz"
local toolkit_url="https://download.pingcap.org/$toolkit_tar_name"
local toolkit_url="https://download.pingcap.com/$toolkit_tar_name"

log_green "Downloading community binaries..."
download_file "$tidb_url" "$tidb_tar_name" "${TMP_DIR}/$tidb_tar_name"
Expand Down
2 changes: 1 addition & 1 deletion tests/integration_tests/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ If you need to specify a version, os or arch, you can use, for example: `make pr
* [jq](https://stedolan.github.io/jq/)
* [minio](https://github.com/minio/minio)

> You could download these binaries by yourself from [tidb-community-toolkit](https://download.pingcap.org/tidb-community-toolkit-v6.0.0-linux-amd64.tar.gz) and [tidb-community-server](https://download.pingcap.org/tidb-community-server-v6.0.0-linux-amd64.tar.gz).
> You could download these binaries by yourself from [tidb-community-toolkit](https://download.pingcap.com/tidb-community-toolkit-v6.0.0-linux-amd64.tar.gz) and [tidb-community-server](https://download.pingcap.com/tidb-community-server-v6.0.0-linux-amd64.tar.gz).

2. These are programs/packages need be installed manually.
* [mysql](https://dev.mysql.com/doc/mysql-installation-excerpt/5.7/en/) (the MySQL cli client,
Expand Down