Feat/add daemon version to status #404
Conversation
- Add version field to DaemonStatus dataclass - Retrieve package version using importlib.metadata with fallback to pyproject.toml - Include version in daemon status response via /api/daemon/status endpoint
Remove complex fallback mechanism for package version. Keep only importlib.metadata.version() which works in production. If it fails, gracefully return None.
There was a problem hiding this comment.
Pull Request Overview
This PR adds version tracking to the daemon by including the package version in the daemon's status information. This enables users and systems to programmatically determine which version of the daemon is running.
Key Changes
- Imports
versionfromimportlib.metadatato retrieve the installed package version - Retrieves and logs the daemon version during initialization with error handling for cases where the version cannot be determined
- Adds a
versionfield to theDaemonStatusdataclass to expose the version information through the status API
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| try: | ||
| package_version = version("reachy_mini") | ||
| self.logger.info(f"Daemon version: {package_version}") | ||
| except Exception: | ||
| package_version = None | ||
| self.logger.warning("Could not determine daemon version") |
There was a problem hiding this comment.
The exception handling is too broad. importlib.metadata.version() specifically raises PackageNotFoundError when a package is not found. Consider catching the specific exception type instead of a bare Exception:
from importlib.metadata import PackageNotFoundError, version
# ...
try:
package_version = version("reachy_mini")
self.logger.info(f"Daemon version: {package_version}")
except PackageNotFoundError:
package_version = None
self.logger.warning("Could not determine daemon version")This makes the error handling more precise and explicit about what failure case is being handled.
| except Exception: | ||
| package_version = None | ||
| self.logger.warning("Could not determine daemon version") | ||
|
|
There was a problem hiding this comment.
Trailing whitespace detected. Please remove the trailing whitespace at the end of this line.
No description provided.