Feat/add daemon version to status #404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add version field to DaemonStatus dataclass - Retrieve package version using importlib.metadata with fallback to pyproject.toml - Include version in daemon status response via /api/daemon/status endpoint
Remove complex fallback mechanism for package version. Keep only importlib.metadata.version() which works in production. If it fails, gracefully return None.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds version tracking to the daemon by including the package version in the daemon's status information. This enables users and systems to programmatically determine which version of the daemon is running.
Key Changes
- Imports
versionfromimportlib.metadatato retrieve the installed package version - Retrieves and logs the daemon version during initialization with error handling for cases where the version cannot be determined
- Adds a
versionfield to theDaemonStatusdataclass to expose the version information through the status API
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/reachy_mini/daemon/daemon.py
Outdated
| except Exception: | ||
| package_version = None | ||
| self.logger.warning("Could not determine daemon version") | ||
|
|
There was a problem hiding this comment.
Trailing whitespace detected. Please remove the trailing whitespace at the end of this line.
Suggested change
pierre-rouanet
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.