Minor build fixes #1046
Merged
Minor build fixes #1046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the value of the environment variable `EXEC_WRAPPER` had to be the name of a binary to be usable with `test/acvp_client.py`. This commit generalizes this to allow a binary name followed by some fixed parameters. Signed-off-by: Hanno Becker <[email protected]>
This commit simplifies the logic around automatically
setting architecture-specific compiler flags from
```
if (arch == A)
{
if (!cross)
...
if (cross == X)
...
elif (cross == Y)
...
}
elif (arch == B)
{
if (!cross)
...
if (cross == X)
...
elif (cross == Y)
...
}
```
to
```
if !cross
{
if (arch == A)
...
elif (arch == B)
...
...
}
else {
if (cross == X)
...
elif (cross == Y)
...
}
```
It also adds further architecture flags for RV64 and PPC64LE.
Signed-off-by: Hanno Becker <[email protected]>
The tches server being unavailable keeps failing our CI. This commit switches to the eprint url of the same paper - that should be more stable. Signed-off-by: Matthias J. Kannwischer <[email protected]>
mkannwischer
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encountered while looking at CI failures in #1037
Allow parameters in EXEC_WRAPPER environment variable:
Previously, the value of the environment variable
EXEC_WRAPPERhad to be the name of a binary to be usable with
test/acvp_client.py.This commit generalizes this to allow a binary name followed by some
fixed parameters.
Makefiles: Simplify auto-derivation of compiler flags
This commit simplifies the logic around automatically
setting architecture-specific compiler flags from
to
It also adds further architecture flags for RV64 and PPC64LE.