Skip to content

Conversation

@prestodb-ci
Copy link
Contributor

@prestodb-ci prestodb-ci commented May 29, 2025

Missing Release Notes

Amit Dutta

Arjun Gupta

Emily (Xuetong) Sun

Gary Helmling

HeidiHan0000

Heng Xiao

Prashant Golash

Pratik Joseph Dabre

Samuel Majoros

Shijin

Xiao Du

Yuanda (Yenda) Li

aditi-pandit

namya28

tanjialiang

Extracted Release Notes

All Commits

Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass and review completed for the release notes.

@github-project-automation github-project-automation bot moved this from 🆕 Unprioritized to 🏗 In progress in Presto Documentation May 29, 2025
Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second review, minor cleanup.

Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review, catch minor formatting.

Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more format issue

@steveburnett
Copy link
Contributor

I am done with the initial review, and have applied my changes. I have pulled the updated branch, made a new doc build, and reviewed the new doc build from beginning to end and I find no more changes I want to suggest at this time.

What I did:

  • verified that the sections are in the correct order, as shown in the Order of sections in the Release Notes Guidelines
  • verified that entries in all sections are in the correct order, as shown in the Order of changes in the Release Note Guidelines - I moved a couple of entries to complete this
  • tested all links, both internal to the Presto doc and external to the rest of the Web, and verified all links a) work and b) go to the correct destination (note: this includes manually testing all generated links to PRs)
  • reviewed for product name accuracy - Delta Lake, MongoDB, and so on - and fixed those as needed
  • edited and revised for other punctuation, formatting, and phrasing

@steveburnett
Copy link
Contributor

steveburnett commented May 29, 2025

The Release Note Shepherd for 0.293 is @aditi-pandit - thank you for volunteering!

I believe that the remaining work for this PR is to:

  • review the PRs in the Missing Release Notes section of this PR
  • identify any of those PRs that should have release notes added for this release
  • write (work with the PR author) any needed release notes and add them to release-0.293.rst
  • re-request a review from me to review the new entries
  • select notable entries and copy those into the Highlights topic in release-0.293.rst
  • squash commits

@aditi-pandit aditi-pandit requested a review from a team as a code owner June 3, 2025 23:23
@github-actions github-actions bot removed the docs label Jun 3, 2025
@aditi-pandit aditi-pandit force-pushed the release-notes-0.293 branch from f234f13 to 6bc0dcb Compare June 3, 2025 23:26
@github-actions github-actions bot added the docs label Jun 3, 2025
Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another review for formatting nits.

Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting and text nits.

Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (docs)

Pull updated branch, new local doc build, looks good. Thanks!

@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Presto Documentation Jun 4, 2025
@github-project-automation github-project-automation bot moved this from ✅ Done to 🏗 In progress in Presto Documentation Jun 4, 2025
@steveburnett steveburnett requested a review from ZacBlanco June 5, 2025 16:35
ZacBlanco
ZacBlanco previously approved these changes Jun 5, 2025
General Changes
_______________
* Fix ROLLBACK statement to ensure it successfully aborts non-auto commit transactions corrupted by failed statements. `#23247 <https://github.com/prestodb/presto/pull/23247>`_
* Fix Router Round robin scheduler candidate cluster index, by adding group specific index. `#24580 <https://github.com/prestodb/presto/pull/24580>`_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Fix Router Round robin scheduler candidate cluster index, by adding group specific index. `#24580 <https://github.com/prestodb/presto/pull/24580>`_
* Fix Round Round robin scheduler candidate cluster index, by adding group specific index. `#24580 <https://github.com/prestodb/presto/pull/24580>`_

Link to doc?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading the PR, it may not be user-facing - it fixes an error so an error isn't thrown. Should I delete this one?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is user facing, it means the user can now use the round robin scheduler without an error being thrown

Copy link
Contributor

@steveburnett steveburnett Jun 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tdcmeehan, Okay that makes sense! I don't know what doc this should be linked to. Can you let me know? Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jp-sivaprasad, @tdcmeehan recommended that the release note entry for your PR #24580 should link to the documentation. I can't find where in the existing Presto doc this should link to.

Please reply with a doc link that we can add here, or that the documentation for this feature doesn't exist.

@steveburnett steveburnett dismissed their stale review June 6, 2025 15:01

Dismissing my own most recent review because my comments in it addressed and fixed comments in others' reviews.

==============

* Fix ROLLBACK statement to ensure it successfully aborts non-auto commit transactions corrupted by failed statements. `#23247 <https://github.com/prestodb/presto/pull/23247>`_
* Improve performance as introducing Thrift serialization. `#25079 <https://github.com/prestodb/presto/pull/25079>`_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Improve performance as introducing Thrift serialization. `#25079 <https://github.com/prestodb/presto/pull/25079>`_
* Improve coordinator performance by introducing Thrift serialization. `#25079 <https://github.com/prestodb/presto/pull/25079>`_

Would be great to get some doc so users know how to enable it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created #25259 following offline discussion.


Prestissimo (Native Execution) Changes
______________________________________
* Fix serialization in batch shuffle to use appropriate sorting keys for each buffer. `#25015 <https://github.com/prestodb/presto/pull/25015>`_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User facing release note. What type of query is affected and what did we fix?

______________________________________
* Fix serialization in batch shuffle to use appropriate sorting keys for each buffer. `#25015 <https://github.com/prestodb/presto/pull/25015>`_
* Add `runtime metrics collection for S3 Filesystem <https://facebookincubator.github.io/velox/monitoring/metrics.html#s3-filesystem>`_. `#24554 <https://github.com/prestodb/presto/pull/24554>`_
* Add support for sorted serialization in batch shuffle. `#24953 <https://github.com/prestodb/presto/pull/24953>`_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the impact from the user's perspective? Needs a user facing release note.

@steveburnett
Copy link
Contributor

@tdcmeehan, @aditi-pandit has updated the PR with revised entries for the open comments. PTAL.

#25222 (comment)

#25222 (comment)

#25222 (comment)

#25222 (comment)

#25222 (comment)

#25222 (comment)

Copy link
Contributor

@tdcmeehan tdcmeehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple nits

@steveburnett steveburnett requested a review from tdcmeehan June 10, 2025 16:56
@steveburnett
Copy link
Contributor

Just a couple nits

@tdcmeehan nits addressed, PTAL.

@unidevel
Copy link
Contributor

Hi, @steveburnett @tdcmeehan @ZacBlanco Since Meta will close the legacy OSSRH maven artifacts publishing on Jun 18th. Can we finish the review before next week so that we can release the maven artifacts for 0.293 before the date to avoid extra effort? Thanks.

@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Presto Documentation Jun 13, 2025
@unidevel
Copy link
Contributor

Thanks @tdcmeehan and @ZacBlanco , @steveburnett please help to take a final look, I'll start the release action once this PR is merged, thanks.

Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (docs)

Commits need to be squashed, but the content is ready to merge.

Co-Authored-By: Steve Burnett <[email protected]>
@unidevel unidevel force-pushed the release-notes-0.293 branch from c7a82ce to ed788c7 Compare June 13, 2025 15:45
@steveburnett steveburnett merged commit 1afbc2b into master Jun 13, 2025
104 checks passed
@steveburnett steveburnett deleted the release-notes-0.293 branch June 13, 2025 19:51
@steveburnett
Copy link
Contributor

@unidevel, I just merged the PR. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants