-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Add release notes for 0.293 #25222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release notes for 0.293 #25222
Conversation
b822baa to
a735793
Compare
steveburnett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass and review completed for the release notes.
steveburnett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Second review, minor cleanup.
steveburnett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review, catch minor formatting.
steveburnett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more format issue
|
I am done with the initial review, and have applied my changes. I have pulled the updated branch, made a new doc build, and reviewed the new doc build from beginning to end and I find no more changes I want to suggest at this time. What I did:
|
|
The Release Note Shepherd for 0.293 is @aditi-pandit - thank you for volunteering! I believe that the remaining work for this PR is to:
|
f234f13 to
6bc0dcb
Compare
steveburnett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another review for formatting nits.
steveburnett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Formatting and text nits.
steveburnett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (docs)
Pull updated branch, new local doc build, looks good. Thanks!
| General Changes | ||
| _______________ | ||
| * Fix ROLLBACK statement to ensure it successfully aborts non-auto commit transactions corrupted by failed statements. `#23247 <https://github.com/prestodb/presto/pull/23247>`_ | ||
| * Fix Router Round robin scheduler candidate cluster index, by adding group specific index. `#24580 <https://github.com/prestodb/presto/pull/24580>`_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * Fix Router Round robin scheduler candidate cluster index, by adding group specific index. `#24580 <https://github.com/prestodb/presto/pull/24580>`_ | |
| * Fix Round Round robin scheduler candidate cluster index, by adding group specific index. `#24580 <https://github.com/prestodb/presto/pull/24580>`_ |
Link to doc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reading the PR, it may not be user-facing - it fixes an error so an error isn't thrown. Should I delete this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is user facing, it means the user can now use the round robin scheduler without an error being thrown
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tdcmeehan, Okay that makes sense! I don't know what doc this should be linked to. Can you let me know? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jp-sivaprasad, @tdcmeehan recommended that the release note entry for your PR #24580 should link to the documentation. I can't find where in the existing Presto doc this should link to.
Please reply with a doc link that we can add here, or that the documentation for this feature doesn't exist.
Dismissing my own most recent review because my comments in it addressed and fixed comments in others' reviews.
| ============== | ||
|
|
||
| * Fix ROLLBACK statement to ensure it successfully aborts non-auto commit transactions corrupted by failed statements. `#23247 <https://github.com/prestodb/presto/pull/23247>`_ | ||
| * Improve performance as introducing Thrift serialization. `#25079 <https://github.com/prestodb/presto/pull/25079>`_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * Improve performance as introducing Thrift serialization. `#25079 <https://github.com/prestodb/presto/pull/25079>`_ | |
| * Improve coordinator performance by introducing Thrift serialization. `#25079 <https://github.com/prestodb/presto/pull/25079>`_ |
Would be great to get some doc so users know how to enable it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created #25259 following offline discussion.
|
|
||
| Prestissimo (Native Execution) Changes | ||
| ______________________________________ | ||
| * Fix serialization in batch shuffle to use appropriate sorting keys for each buffer. `#25015 <https://github.com/prestodb/presto/pull/25015>`_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
User facing release note. What type of query is affected and what did we fix?
| ______________________________________ | ||
| * Fix serialization in batch shuffle to use appropriate sorting keys for each buffer. `#25015 <https://github.com/prestodb/presto/pull/25015>`_ | ||
| * Add `runtime metrics collection for S3 Filesystem <https://facebookincubator.github.io/velox/monitoring/metrics.html#s3-filesystem>`_. `#24554 <https://github.com/prestodb/presto/pull/24554>`_ | ||
| * Add support for sorted serialization in batch shuffle. `#24953 <https://github.com/prestodb/presto/pull/24953>`_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the impact from the user's perspective? Needs a user facing release note.
|
@tdcmeehan, @aditi-pandit has updated the PR with revised entries for the open comments. PTAL. |
tdcmeehan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple nits
@tdcmeehan nits addressed, PTAL. |
|
Hi, @steveburnett @tdcmeehan @ZacBlanco Since Meta will close the legacy OSSRH maven artifacts publishing on Jun 18th. Can we finish the review before next week so that we can release the maven artifacts for 0.293 before the date to avoid extra effort? Thanks. |
|
Thanks @tdcmeehan and @ZacBlanco , @steveburnett please help to take a final look, I'll start the release action once this PR is merged, thanks. |
steveburnett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (docs)
Commits need to be squashed, but the content is ready to merge.
Co-Authored-By: Steve Burnett <[email protected]>
c7a82ce to
ed788c7
Compare
|
@unidevel, I just merged the PR. Thanks! |
Missing Release Notes
Amit Dutta
Arjun Gupta
Emily (Xuetong) Sun
Gary Helmling
HeidiHan0000
Heng Xiao
Prashant Golash
Pratik Joseph Dabre
Samuel Majoros
Shijin
Xiao Du
Yuanda (Yenda) Li
aditi-pandit
namya28
tanjialiang
Extracted Release Notes
arrays_overlap(x, y) -> booleanfunction does not return the correct value.CVE-2024-43709 <https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2024-43709>_.hive.metastore.catalog.nameto pass catalog names to the metastore, enabling catalog-based schema management and filtering.SHOW CREATE SCHEMA.CVE-2023-44981 <https://nvd.nist.gov/vuln/detail/cve-2023-44981>_.hive.s3.webidentity.enabledproperty.CVE-2014-0114 <https://nvd.nist.gov/vuln/detail/CVE-2014-0114>_.CVE-2017-1000487 <https://nvd.nist.gov/vuln/detail/cve-2017-1000487>_.exchange.compression-enabled,fragment-result-cache.block-encoding-compression-enabled,experimental.spill-compression-enabledwithexchange.compression-codec,fragment-result-cache.block-encoding-compression-codecto enable compression codec configurations. Supported codecs include GZIP, LZ4, LZO, SNAPPY, ZLIB and ZSTD.Unknown connectorerrors using the Nessie catalog.TimeTypein Iceberg table.v1/operator/task/getDetails?id=crash.register-test-functionsworker config #24853 (Author: Pramod Satya): [native] Removeregister-test-functionsworker configregister-test-functions.native-execution-type-rewrite-enabledconfiguration property andnative_execution_type_rewrite_enabledsession property. :pr:24916.AppendFilesoverRowDeltain insert-only statement #24989 (Author: wangd): [Iceberg]PreferAppendFilesoverRowDeltain insert-only statement25022.SimplifyPlanWithEmptyInputoptimizer to convert a table scan which returns no data to an empty values node.Content-Security-Policy,X-Content-Type-Options. See reference docsContent-Security-Policy <https://developer.mozilla.org/en-US/docs/Web/HTTP/CSP>_ andX-Content-Type-Options <https://learn.microsoft.com/en-us/previous-versions/windows/internet-explorer/ie-developer/compatibility/gg622941(v=vs.85)>_. :pr:24272.All Commits
AppendFilesoverRowDeltain insert-only statement (wangd)ELEMENT_ATreturns NULL when out of bounds (ebonnal)isEntireColumn(wangd)