Output VCD file compliant with the standard #291
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @oscargus ! I will take a look next week. I will test this out with our workflows. I don't imagine there will be any issues in which case I can merge this in. I appreciate your help! |
cbatten
reviewed
Aug 22, 2025
| @@ -529,3 +529,7 @@ def oct( self ): | |||
| def hex( self ): | |||
| str = "{:x}".format(int(self._uint)).zfill(((self._nbits-1)//4)+1) | |||
| return "0x"+str | |||
|
|
|||
| def bin_vcd(self): | |||
There was a problem hiding this comment.
The method is named bin_vcd but then we call vcd_bin in the code below?
|
Looks like there might be a discrepancy between the method name and what is used to call that method. Let me try implementing these fixes in a branch in the pymtl3 repo. |
|
I think this is now fixed on the main branch: @oscargus thanks for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #269
(It was so quick, so I took a chance that it will be merged etc...)
I have no idea how to run to generate a VCD file though, but assuming that this is the sole file responsible for it and my search for locations didn't fail...