Ignore -headerpad_max_install_names and -dead_strip_dylibs for wasm-ld
#168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agriyakhetarpal
changed the title
-headerpad_max_install_names and -dead_strip_dylibs for wasm-ld-headerpad_max_install_names and -dead_strip_dylibs for wasm-ld
agriyakhetarpal
added a commit
that referenced
this pull request
Jun 29, 2025
agriyakhetarpal
changed the title
-headerpad_max_install_names and -dead_strip_dylibs for wasm-ld-headerpad_max_install_names and -dead_strip_dylibs for wasm-ld
This was referenced Jun 29, 2025
agriyakhetarpal
force-pushed
the
fix/macos-numpy-failure
branch
from
9b68889 to
b47be36
Compare
agriyakhetarpal
added a commit
that referenced
this pull request
Jun 29, 2025
ryanking13
reviewed
Jun 30, 2025
| # macOS-specific linker flags that wasm-ld doesn't understand | ||
| "-headerpad_max_install_names", | ||
| "-dead_strip_dylibs", | ||
| ]: |
There was a problem hiding this comment.
It is not related to this PR, but I think we can do some micro optimization here:
- Let's change the list to a set for fast check
- Initialize the set before for loop
There was a problem hiding this comment.
Indeed, that makes sense. I'll take that up in a new PR!
ryanking13
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These arguments are inserted by Meson when compiling on a macOS machine on a few occasions; see numpy/numpy#28642 for greater discussion. This PR filters them out, as
wasm-ldraises errors if it sees them.This PR does not address the original issue, i.e., as to why Meson adds these arguments. The apparent cause is the use of shared libraries,
libopenblas.soin this case + the fact that we are "mocking" cross compilation in a way through pywasmcross and therefore Meson isn't smart enough to not add them. This PR is not strictly required; however, this PR is useful in its own right, as it helps compilation succeed on macOS on some occasions.Reference
https://manp.gs/mac/1/ld#dead_strip_dylibs
https://manp.gs/mac/1/ld#headerpad_max_install_names
PR stack
Please review the following PRs in the order listed below:
-headerpad_max_install_namesand-dead_strip_dylibsforwasm-ld#168 ➡️ you are here__Pyx_IsSameCFunction#213pyodide-buildrepository as a submodule pyodide-recipes#140