Fix signatures for function pointers passed through __Pyx_IsSameCFunction
#213
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The rationale here is that in C code generated by Cython when compiling SciPy,
__Pyx_IsSameCFunction
usually carriesvoid
types for extension modules, but we need to cast toint
s instead. As this phenomenon occurs during the code generation steps where the generated files are not addressable via patches orsed
commands, we therefore handle it viascipy_fix_cfile()
here.Tip
This PR builds upon the changes made in #168, and it is the second PR in a series of PRs to build newer versions of SciPy; please review that PR first.
PR stack
Please review the following PRs in the order listed below:
-headerpad_max_install_names
and-dead_strip_dylibs
forwasm-ld
#168__Pyx_IsSameCFunction
#213 ➡️ you are herepyodide-build
repository as a submodule pyodide-recipes#140