Skip to content

Conversation

agriyakhetarpal
Copy link
Member

@agriyakhetarpal agriyakhetarpal commented Jun 29, 2025

Description

This PR adds pyodide-build as a submodule, just like it is the case in the Pyodide main/runtime repository. This has a few advantages:

  • being able to test out changes to pyodide-build to assess breakages for new changes or compatibility with older changes
  • being able to modify compilation routines such as pywasmcross.py to assess changes
  • being able to test out ABI changes with new nightly xbuildenvs
  • and so on

As we've pinned our Pyodide build environment in pyproject.toml in the repository root, this PR does not introduce any ABI or compilation-specific changes.

Note

The note below has been resolved; the submodule points to pyodide/pyodide-build@ee11882 on the main branch now.

Tip

The submodule checked in this PR builds upon my branch, which I've submitted as a PR at pyodide/pyodide-build#213. Once merged, I shall update the submodule to point to main. Please review that PR first. Thank you!

PR stack

Please review the following PRs in the order listed below:

Copy link
Contributor

github-actions bot commented Jun 29, 2025

Package Build Results

Total packages built: 28
Total build time: 0:02:34

Package Build Times (click to expand)
Package Build Time
openssl 2m 29s
sqlite3 1m 7s
liblzma 1m 2s
test 25s
regex 12s
pydecimal 4s
MarkupSafe 4s
pydoc_data 4s
ssl 4s
atomicwrites 3s
lzma 3s
hashlib 3s
packaging 2s
setuptools 1s
pytz 1s
attrs 1s
iniconfig 0s
six 0s
micropip 0s
exceptiongroup 0s
pyparsing 0s
more-itertools 0s
Jinja2 0s
pytest 0s
tblib 0s
pytest-asyncio 0s
py 0s
pluggy 0s

Longest build: openssl (2m 29s)
Packages built in more than 10 minutes: 0

Copy link
Member

@ryanking13 ryanking13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I hope we can stop using pyodide-build submodule someday, both in pyodide/pyodide and here, when pyodide-build is stable enough to handle most of the edge cases. But for now, it looks good to me.

@ryanking13
Copy link
Member

I'll review the corresponding PRs too.

@agriyakhetarpal
Copy link
Member Author

Thanks! I hope we can stop using pyodide-build submodule someday, both in pyodide/pyodide and here, when pyodide-build is stable enough to handle most of the edge cases. But for now, it looks good to me.

I agree! We've made significant progress in making its various parts extensible and overrideable, so perhaps not much more would be needed to achieve this.

@agriyakhetarpal
Copy link
Member Author

Thank you for the review!

@agriyakhetarpal agriyakhetarpal merged commit c70db15 into pyodide:main Jun 30, 2025
4 checks passed
@agriyakhetarpal agriyakhetarpal deleted the add-pyodide-build-submodule branch June 30, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants