Add pyodide-build
repository as a submodule
#140
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
pyodide-build
as a submodule, just like it is the case in the Pyodide main/runtime repository. This has a few advantages:pyodide-build
to assess breakages for new changes or compatibility with older changespywasmcross.py
to assess changesAs we've pinned our Pyodide build environment in
pyproject.toml
in the repository root, this PR does not introduce any ABI or compilation-specific changes.Note
The note below has been resolved; the submodule points to pyodide/pyodide-build@ee11882 on the
main
branch now.Tip
The submodule checked in this PR builds upon my branch, which I've submitted as a PR at pyodide/pyodide-build#213. Once merged, I shall update the submodule to point tomain
. Please review that PR first. Thank you!PR stack
Please review the following PRs in the order listed below:
-headerpad_max_install_names
and-dead_strip_dylibs
forwasm-ld
pyodide-build#168__Pyx_IsSameCFunction
pyodide-build#213pyodide-build
repository as a submodule #140 ➡️ you are here