Skip to content

Qualcomm AI Engine Direct - Support more SoC model #6954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Qualcomm AI Engine Direct - Support more SoC model #6954

wants to merge 1 commit into from

Conversation

@DannyYuyang-quic
Copy link
Contributor

@DannyYuyang-quic DannyYuyang-quic commented Nov 19, 2024

Summary

  • support Snapdragon 8s Gen 3
  • support Snapdragon 8 Elite

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 19, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6954

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit c01226d with merge base cf8d0cf (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 19, 2024

Hi @DannyYuyang-quic!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

cccclai
cccclai approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cccclai
Copy link
Contributor

cccclai commented Nov 20, 2024

Hi @DannyYuyang-quic, looks like you haven't signed CLA yet. Can you follow https://github.com/pytorch/executorch/pull/6954/checks?check_run_id=33182189016 and sign it?

@chiwwang
Copy link
Contributor

chiwwang commented Nov 20, 2024 •
edited
Loading

I'm contacting QC POC for Meta CLA... it seems only 1 person in QC can approve this.

cccclai
cccclai reviewed Dec 5, 2024
View reviewed changes
backends/qualcomm/serialization/qc_compiler_spec.fbs
SM8475 = 42,
SM8550 = 43,
SSG2115P = 46,
SM8635 = 68,
Copy link
Contributor

@cccclai cccclai Dec 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated - we may need to figure out how to make it non BC breaking. I remember extending in flatbuffers won't be BC breacking, but it'll a bit annoying if it's not ordered...

@cccclai
Copy link
Contributor

cccclai commented Dec 5, 2024

Is the SLA issue resolved?

@DannyYuyang-quic
Qualcomm AI Engine Direct - Support more SoC model
c01226d 
    Summary:
    - support Snapdragon 8s Gen 3
    - support Snapdragon 8 Elite
@chunit-quic chunit-quic force-pushed the dev1/danny/support_v79_v68 branch from a4fa2f9 to c01226d Compare January 16, 2025 01:22
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 12, 2025
@cccclai
Copy link
Contributor

cccclai commented Apr 7, 2025

I guess another PR is merged instead? Do we still need this?

@DannyYuyang-quic
Copy link
Contributor Author

DannyYuyang-quic commented Apr 8, 2025

I guess another PR is merged instead? Do we still need this?

Yes, we can close this PR now.

@cccclai cccclai closed this Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cccclai cccclai cccclai approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DannyYuyang-quic @facebook-github-bot @cccclai @chiwwang