- 
                Notifications
    
You must be signed in to change notification settings  - Fork 712
 
create and validate build_variables.bzl #8326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
          
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8326
 Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 7f2ca6a with merge base 70ab5ab ( NEW FAILURE - The following job has failed:
 
 This comment was automatically generated by Dr. CI and updates every 15 minutes.  | 
    
| 
           Current error: So, we need a mechanism for choosing fht_avx.c on Intel and fht_neon.c on ARM. Best way is probably to add a CMake-native way to do this and filter these files out of the Buck-to-CMake pipeline.  | 
    
First step of #8268 -- we are moving from buck-extracted filelist to using one shared filelist, and the first step is to create the shared filelist and validate it against the buck generation. ghstack-source-id: c4195ce ghstack-comment-id: 2644414497 Pull Request resolved: pytorch/executorch#8326
[ghstack-poisoned]
| 
           @swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.  | 
    
| 
           @swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.  | 
    
First step of pytorch#8268 -- we are moving from buck-extracted filelist to using one shared filelist, and the first step is to create the shared filelist and validate it against the buck generation. Differential Revision: [D80187441](https://our.internmc.facebook.com/intern/diff/D80187441)
Making the structure in this file mirror buck's worldview more closely when it makes sense. pytorch#8268 (Also piggybacked a fixup for a continue() I left for this target in pytorch#8326.)
First step of #8268 -- we are moving from buck-extracted filelist to using one shared filelist, and the first step is to create the shared filelist and validate it against the buck generation.
Differential Revision: D80187441