Skip to content

Conversation

@swolchok
Copy link
Contributor

@swolchok swolchok commented Feb 12, 2025

Making the structure in this file mirror buck's worldview more closely when it makes sense. #8268

Differential Revision: D80187446

[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Feb 12, 2025

@pytorch-bot
Copy link

pytorch-bot bot commented Feb 12, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8397

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 12 Pending

As of commit e5953eb with merge base 2c0752a (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

wait, why are there 30 commits here?

[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@swolchok swolchok added the release notes: none Do not include this in the release notes label Aug 13, 2025
@swolchok
Copy link
Contributor Author

@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@swolchok
Copy link
Contributor Author

@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Base automatically changed from gh/swolchok/240/head to main August 13, 2025 20:43
@swolchok swolchok requested a review from larryliu0820 as a code owner August 13, 2025 20:43
@swolchok
Copy link
Contributor Author

noting tests look good

[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

@swolchok has imported this pull request. If you are a Meta employee, you can view this in D80187446.

@swolchok swolchok merged commit 4a1cbac into main Aug 15, 2025
103 of 104 checks passed
@swolchok swolchok deleted the gh/swolchok/253/head branch August 15, 2025 18:20
agrima1304 pushed a commit to agrima1304/executorch that referenced this pull request Aug 26, 2025
…ORE_SRCS (pytorch#8397)

Making the structure in this file mirror buck's worldview more closely
when it makes sense. pytorch#8268

Differential Revision:
[D80187446](https://our.internmc.facebook.com/intern/diff/D80187446)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants