build_variables.bzl: split PLATFORM_SRCS from EXECUTORCH_CORE_SRCS #8398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8398
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 73 PendingAs of commit b219e9b with merge base 8e208ad ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Feb 12, 2025
facebook-github-bot
added
the
CLA Signed
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
|
@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
|
@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
tests look good |
This was referenced Aug 13, 2025
This was referenced Aug 14, 2025
|
noting CI is good |
GregoryComer
approved these changes
Aug 15, 2025
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
agrima1304
pushed a commit
to agrima1304/executorch
that referenced
this pull request
Aug 26, 2025
…ytorch#8398) Making the structure in this file mirror buck's worldview more closely when it makes sense. pytorch#8268
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making the structure in this file mirror buck's worldview more closely when it makes sense. #8268