[ExecuTorch][XNNPACK] validate quant params before lowering #9299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there have been some invalid scales/zp sneaking into our serialized quant tensors. This has been annoying because it seemingly passes the export stage. Adding some asserts to help identify the node, the buggy scale/zp value, and the index in to that tensor if applicable Differential Revision: [D70775365](https://our.internmc.facebook.com/intern/diff/D70775365/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9299
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 9444e87 with merge base 445ff34 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
mcr229
added a commit
that referenced
this pull request
Mar 14, 2025
there have been some invalid scales/zp sneaking into our serialized quant tensors. This has been annoying because it seemingly passes the export stage. Adding some asserts to help identify the node, the buggy scale/zp value, and the index in to that tensor if applicable Differential Revision: [D70775365](https://our.internmc.facebook.com/intern/diff/D70775365/) ghstack-source-id: 271918085 Pull Request resolved: #9299
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D70775365 |
GregoryComer
approved these changes
Mar 15, 2025
there have been some invalid scales/zp sneaking into our serialized quant tensors. This has been annoying because it seemingly passes the export stage. Adding some asserts to help identify the node, the buggy scale/zp value, and the index in to that tensor if applicable Differential Revision: [D70775365](https://our.internmc.facebook.com/intern/diff/D70775365/) [ghstack-poisoned]
mcr229
added a commit
that referenced
this pull request
Mar 19, 2025
Pull Request resolved: #9299 there have been some invalid scales/zp sneaking into our serialized quant tensors. This has been annoying because it seemingly passes the export stage. Adding some asserts to help identify the node, the buggy scale/zp value, and the index in to that tensor if applicable ghstack-source-id: 272845697 Differential Revision: [D70775365](https://our.internmc.facebook.com/intern/diff/D70775365/)
|
This pull request was exported from Phabricator. Differential Revision: D70775365 |
facebook-github-bot
merged commit 381360e
into
gh/mcr229/12/base
79 of 82 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
there have been some invalid scales/zp sneaking into our serialized quant tensors. This has been annoying because it seemingly passes the export stage. Adding some asserts to help identify the node, the buggy scale/zp value, and the index in to that tensor if applicable
Differential Revision: D70775365