Skip to content

Conversation

@tomerqodo
Copy link

Benchmark PR calcom#26717

Type: Corrupted (contains bugs)

Original PR Title: refactor: Remove trpc/server dependency from @calcom/atoms
Original PR Description: ## What does this PR do?

  • Decouples the atoms package from trpc/server

Impact

Screenshot 2026-01-12 at 4 04 37 AM

Summary of Changes

Type Migrations:

  • Moved Slot type to @calcom/atoms/booker/types (removed from trpc/server)
  • Added GetAvailableSlotsResponse type with SlotInfo to booker/types.ts
  • Created local types in hooks/schedules/types.ts:
    • Schedule (with userId for create/duplicate handlers)
    • CreateScheduleHandlerReturn, DuplicateScheduleHandlerReturn, GetAvailabilityListHandlerReturn
    • CreateScheduleInput

Import Updates:

  • Updated useAtomCreateSchedule, useAtomDuplicateSchedule, useAtomGetAllSchedules to use local types
  • Updated useAvailableSlots.ts to use local GetAvailableSlotsResponse

Config Changes:

  • Updated Biome rule to block ALL @calcom/trpc imports (not just @calcom/trpc/react)
  • Removed trpc paths from atoms tsconfig.json
  • Updated package.json exports

Updates since last revision

  • Fixed TypeScript operator precedence issue in GetAvailabilityListHandlerReturn type: wrapped intersection type in parentheses so [] creates an array of the intersection type rather than an intersection with an array type (addresses Cubic AI review feedback)

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

Original PR URL: calcom#26717

@github-actions
Copy link

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "[CORRUPTED] Synthetic Benchmark PR #26717 - refactor: Remove trpc/server dependency from @calcom/atoms". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@github-actions
Copy link

This PR has been marked as stale due to inactivity. If you're still working on it or need any help, please let us know or update the PR to keep it active.

@github-actions github-actions bot added the Stale label Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants