Skip to content

Conversation

gordonwoodhull
Copy link
Contributor

@gordonwoodhull gordonwoodhull commented Apr 10, 2025

By using light, dark, light stylesheets for author preference: light

Then disable the final light stylesheet in the before-body script.

Do not disable the initial light stylesheet when entering dark mode.

Test website with quarto-web deployed:
https://gordonwoodhull.github.io/quarto-web-safari-bugless/

Note that author-prefers-light is now the "weird case", even though it is the common case. So this deployment exercises all the changes. author-prefers-dark webpages are unchanged by this PR.

and then disable the extra stylesheet in the before-body script
@cscheid cscheid merged commit 5f298cf into main Apr 10, 2025
49 checks passed
@cscheid cscheid deleted the bugfix/light-overlays-dark branch April 10, 2025 18:29
gordonwoodhull added a commit that referenced this pull request Apr 11, 2025
when author preference is light, we need a last light stylesheet for NoJS
same principal as #12514
implementation is much worse

includes a test which will still fail due to a11y stylesheet bleed #12522
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants