Skip to content

Home page template #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 27, 2022
Merged

Home page template #27

merged 6 commits into from
Jan 27, 2022

Conversation

@nienn
Copy link
Contributor

@nienn nienn commented Jan 13, 2022

Again, just moving code from mockups to templates.

@nienn nienn requested a review from a team as a code owner January 13, 2022 15:30
@agjohnson
Copy link
Contributor

It seems this is blocked on the copy conversation in #23

@agjohnson agjohnson added the Status: blocked Issue is blocked on another issue label Jan 17, 2022
@nienn nienn mentioned this pull request Jan 18, 2022
Merged
@agjohnson agjohnson removed the Status: blocked Issue is blocked on another issue label Jan 20, 2022
@agjohnson
Copy link
Contributor

Copy conversation is merged, this can continue.

@nienn nienn changed the base branch from nienn/footer-template to main January 20, 2022 18:46
agjohnson
agjohnson reviewed Jan 25, 2022
View reviewed changes
Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear if this was ready for review, but I'm noticing missing copy changes from the previous PR.

readthedocs-theme/templates/readthedocs/homepage.html Outdated
<img src="/theme/img/infographic-01.png"/>
</div>
<p>
Write your documentation easily, using .md or .rst, directly in your own IDE, as you work on what maters: your project.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hrm. I noted in the previous PR that this should be Markdown and reStructuredText, not .md or .rst. Seems we missed some of the review feedback in the previous PR. Is this not yet ready for review?

readthedocs-theme/templates/readthedocs/homepage.html Outdated
<img src="/theme/img/infographic-03.png"/>
</div>
<p>
Setup your account with Read the Docs, add a .config file to tell us your preferences and we'll do the rest!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, here too, this is missing review contributions from the last PR.

@nienn nienn force-pushed the nienn/home-page-template branch from 0e029e5 to 6040ecf Compare January 25, 2022 15:50
@nienn
Copy link
Contributor Author

nienn commented Jan 25, 2022 •
edited
Loading

Ups, I just now realised that Juan's PR #23 was done over the mockup/ files and, of course, that would not update the templates/ when rebased. It's now rebased and I also ported the changes to the templates manually. Should be ready for review now.

Same in #28.

@nienn nienn mentioned this pull request Jan 27, 2022
Closed
agjohnson
agjohnson approved these changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge! We'll do another round of changes after the existing pages are merged in.

@agjohnson agjohnson merged commit 8fb3296 into main Jan 27, 2022
@nienn nienn deleted the nienn/home-page-template branch January 31, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agjohnson agjohnson agjohnson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nienn @agjohnson