RHIDP-8709: Scorecard plugin #1465
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-1465/ @ 10/30/25 17:30:16 |
pabel-rh
added
Peer review needed 📖
do-no-merge/review-in-progress 👀
Technical review needed 🔩
imykhno
reviewed
Oct 29, 2025
modules/observe/scorecards/proc-configuring-jira-scorecards-in-rhdh-instance.adoc
Show resolved
Hide resolved
modules/observe/scorecards/proc-configuring-jira-scorecards-in-rhdh-instance.adoc
Outdated
Show resolved
Hide resolved
modules/observe/scorecards/proc-configuring-jira-scorecards-in-rhdh-instance.adoc
Outdated
Show resolved
Hide resolved
modules/observe/scorecards/proc-configuring-jira-scorecards-in-rhdh-instance.adoc
Show resolved
Hide resolved
dzemanov
requested changes
Oct 30, 2025
modules/observe/scorecards/proc-authenticating-and-managing-scorecard-plugins.adoc
Outdated
Show resolved
Hide resolved
dzemanov
requested changes
Oct 30, 2025
modules/observe/scorecards/proc-installing-scorecard-plugin-in-rhdh-instance.adoc
Show resolved
Hide resolved
dzemanov
requested changes
Oct 30, 2025
modules/observe/scorecards/proc-configuring-github-scorecards-in-rhdh-instance.adoc
Outdated
Show resolved
Hide resolved
modules/observe/scorecards/proc-configuring-jira-scorecards-in-rhdh-instance.adoc
Show resolved
Hide resolved
modules/observe/scorecards/proc-configuring-jira-scorecards-in-rhdh-instance.adoc
Outdated
Show resolved
Hide resolved
modules/observe/scorecards/proc-configuring-jira-scorecards-in-rhdh-instance.adoc
Outdated
Show resolved
Hide resolved
modules/observe/scorecards/proc-configuring-jira-scorecards-in-rhdh-instance.adoc
Outdated
Show resolved
Hide resolved
modules/observe/scorecards/proc-installing-scorecard-plugin-in-rhdh-instance.adoc
Outdated
Show resolved
Hide resolved
modules/observe/scorecards/proc-configuring-jira-scorecards-in-rhdh-instance.adoc
Show resolved
Hide resolved
modules/observe/scorecards/proc-configuring-github-scorecards-in-rhdh-instance.adoc
Outdated
Show resolved
Hide resolved
dzemanov
requested changes
Oct 30, 2025
modules/observe/scorecards/con-best-practices-for-threshold-rules.adoc
Outdated
Show resolved
Hide resolved
|
Thank you @pabel-rh for the PR, I have requested some changes but we are almost there. |
dzemanov
requested changes
Oct 30, 2025
modules/observe/scorecards/con-set-global-standards-for-metric-thresholds.adoc
Outdated
Show resolved
Hide resolved
modules/observe/scorecards/con-best-practices-for-threshold-rules.adoc
Outdated
Show resolved
Hide resolved
modules/observe/scorecards/proc-configuring-jira-scorecards-in-rhdh-instance.adoc
Show resolved
Hide resolved
modules/observe/scorecards/proc-authenticating-and-managing-scorecard-plugins.adoc
Outdated
Show resolved
Hide resolved
dzemanov
reviewed
Oct 30, 2025
modules/observe/scorecards/con-best-practices-for-threshold-rules.adoc
Outdated
Show resolved
Hide resolved
dzemanov
approved these changes
Oct 30, 2025
imykhno
approved these changes
Oct 30, 2025
pabel-rh
added
Technical review done ⛅
dzemanov
requested changes
Oct 31, 2025
|
|
||
| . Add GitHub credentials to your {product-very-short} secrets. | ||
| + | ||
| Set the following key/value pairs as environment variables in your secrets store: |
There was a problem hiding this comment.
Can you use what is in the draft for this section please?
E.g it was changed to:
Add your GitHub credentials to your Developer Hub secrets using the following key/value pairs. You can use these secrets in the Developer Hub configuration files by using their respective environment variable names.
And it would be good to also link to our docs that explain how to setup secrets.
| token: ${JIRA_TOKEN} | ||
| product: datacenter # Change to 'cloud' if using Jira Cloud | ||
| ---- | ||
| where: |
There was a problem hiding this comment.
Everywhere where we use these variables, we should specify that they should be added as secrets
| `product`:: Enter the supported product: `cloud` or `datacenter`. | ||
|
|
||
| .. Use a proxy setup: In your `{product-very-short} dynamic-plugins-config.yaml`, add the following code: | ||
| + |
There was a problem hiding this comment.
Some command line examples and tables have additional + sign before them, is it expected? And if not, can you please remove those?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Do Not Merge - To be merged by Docs Team Only
Version(s):
1.8, main
Issue:
RHIDP-8709
Preview:
https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-1465/scorecard-plugin/