proto: Alias prefix and prefixed #28807

michael-redpanda · 2025-12-02T21:56:15Z

To reduce confusion, this change introduces aliasing:

ACLPattern.ACL_PATTERN_PREFIX to ACLPattern.ACL_PATTERN_PREFIXED
PatternType.PATTERN_TYPE_PREFIXED to PatternType.PATTERN_TYPE_PREFIX

Fixes: CORE-14886

Backports Required

Release Notes

Improvements

Aliases the following enum variants:
- ACLPattern.ACL_PATTERN_PREFIX to ACLPattern.ACL_PATTERN_PREFIXED
- PatternType.PATTERN_TYPE_PREFIXED to PatternType.PATTERN_TYPE_PREFIX

Copilot

Pull request overview

This PR introduces enum aliasing to reduce confusion around naming inconsistency between "PREFIX" and "PREFIXED" variants in the protobuf definitions. It adds aliases so that both naming conventions can be used interchangeably:

ACLPattern.ACL_PATTERN_PREFIX as an alias for ACL_PATTERN_PREFIXED
PatternType.PATTERN_TYPE_PREFIXED as an alias for PATTERN_TYPE_PREFIX

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
proto/redpanda/core/common/v1/acl.proto	Adds `allow_alias` option and creates `ACL_PATTERN_PREFIX` as alias for existing `ACL_PATTERN_PREFIXED`
proto/redpanda/core/admin/v2/shadow_link.proto	Adds `allow_alias` option and creates `PATTERN_TYPE_PREFIXED` as alias for existing `PATTERN_TYPE_PREFIX`
tests/rptest/clients/admin/proto/redpanda/core/common/v1/acl_pb2.py	Auto-generated Python code reflecting the ACLPattern alias addition
tests/rptest/clients/admin/proto/redpanda/core/common/v1/acl_pb2.pyi	Auto-generated Python type stubs for ACLPattern alias
tests/rptest/clients/admin/proto/redpanda/core/admin/v2/shadow_link_pb2.py	Auto-generated Python code reflecting the PatternType alias addition
tests/rptest/clients/admin/proto/redpanda/core/admin/v2/shadow_link_pb2.pyi	Auto-generated Python type stubs for PatternType alias
tests/rptest/clients/admin/proto/redpanda/core/admin/v2/init.pyi	Adds internal module import

tests/rptest/clients/admin/proto/redpanda/core/admin/v2/__init__.pyi

vbotbuildovich · 2025-12-03T00:12:47Z

CI test results

test results on build#77216

test_class	test_method	test_arguments	test_kind	job_url	test_status	passed	reason	test_history
PartitionForceReconfigurationTest	test_basic_reconfiguration	{"acks": -1, "controller_snapshots": false, "restart": true}	integration	https://buildkite.com/redpanda/redpanda/builds/77216#019ae137-4268-47f9-8268-04dac638bc12	FLAKY	20/21	upstream reliability is '100.0'. current run reliability is '95.23809523809523'. drift is 4.7619 and the allowed drift is set to 50. The test should PASS	https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=PartitionForceReconfigurationTest&test_method=test_basic_reconfiguration
WriteCachingFailureInjectionE2ETest	test_crash_all	{"use_transactions": false}	integration	https://buildkite.com/redpanda/redpanda/builds/77216#019ae139-24f0-41bb-a20d-36673c10aec2	FLAKY	17/21	upstream reliability is '90.13452914798206'. current run reliability is '80.95238095238095'. drift is 9.18215 and the allowed drift is set to 50. The test should PASS	https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=WriteCachingFailureInjectionE2ETest&test_method=test_crash_all

test results on build#77252

test_class	test_method	test_arguments	test_kind	job_url	test_status	passed	reason	test_history
DatalakeDLQTest	test_dlq_table_for_mixed_records	{"catalog_type": "rest_jdbc", "cloud_storage_type": 1, "query_engine": "spark"}	integration	https://buildkite.com/redpanda/redpanda/builds/77252#019ae475-5d78-450d-b8f3-b493a86b8f7b	FLAKY	19/21	upstream reliability is '99.7005988023952'. current run reliability is '90.47619047619048'. drift is 9.22441 and the allowed drift is set to 50. The test should PASS	https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=DatalakeDLQTest&test_method=test_dlq_table_for_mixed_records
PartitionReassignmentsTest	test_reassignments_cancel	null	integration	https://buildkite.com/redpanda/redpanda/builds/77252#019ae475-5d7a-4bf8-98ba-f063804f1e09	FLAKY	16/21	upstream reliability is '97.52475247524752'. current run reliability is '76.19047619047619'. drift is 21.33428 and the allowed drift is set to 50. The test should PASS	https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=PartitionReassignmentsTest&test_method=test_reassignments_cancel

test results on build#77414

test_class	test_method	test_arguments	test_kind	job_url	test_status	passed	reason	test_history
ControllerUpgradeTest	test_updating_cluster_when_executing_operations	null	integration	https://buildkite.com/redpanda/redpanda/builds/77414#019aef0e-9c28-4c9e-a346-e6d2334a7dbd	FLAKY	22/31	Test PASSES after retries.No significant increase in flaky rate(baseline=0.1359, p0=0.0427, reject_threshold=0.0100. adj_baseline=0.3549, p1=0.2085, trust_threshold=0.5000)	https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=ControllerUpgradeTest&test_method=test_updating_cluster_when_executing_operations
NodesDecommissioningTest	test_decommissioning_rebalancing_node	{"shutdown_decommissioned": false}	integration	https://buildkite.com/redpanda/redpanda/builds/77414#019aef0e-9c2b-4035-bc51-a6670c09fcea	FLAKY	21/31	Test FAILS after retries.Significant increase in flaky rate(baseline=0.0843, p0=0.0006, reject_threshold=0.0100)	https://redpanda.metabaseapp.com/dashboard/87-tests?tab=142-dt-individual-test-history&test_class=NodesDecommissioningTest&test_method=test_decommissioning_rebalancing_node

proto/redpanda/core/admin/v2/shadow_link.proto

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

.github/workflows/buf.yml

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

.github/workflows/buf.yml

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated no new comments.

.github/workflows/buf.yml

buf.yaml

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated no new comments.

michael-redpanda · 2025-12-05T14:25:50Z

Force push:

Added check for buf skip breaking label in buf workflow
Narrowed enum alias exception to shadow_link.proto and acl.proto

Signed-off-by: Michael Boquard <[email protected]>

To reduce confusion, this change introduces aliasing: * ACLPattern.ACL_PATTERN_PREFIX to ACLPattern.ACL_PATTERN_PREFIXED * PatternType.PATTERN_TYPE_PREFIXED to PatternType.PATTERN_TYPE_PREFIX Signed-off-by: Michael Boquard <[email protected]>

michael-redpanda · 2025-12-05T14:27:01Z

Force push:

Actually make the paths correct

rockwotj · 2025-12-05T14:47:41Z

.github/workflows/buf.yml

          lint: true
          format: false  # We use clang-tidy
-          breaking: false  # flip to true when we have a release
+          breaking: ${{ github.event_name == 'pull_request' && !contains(github.event.pull_request.labels.*.name, 'buf skip breaking') }} # Enable breaking change check unless the label 'buf skip breaking' is set


Suggested change

breaking: ${{ github.event_name == 'pull_request' && !contains(github.event.pull_request.labels.*.name, 'buf skip breaking') }} # Enable breaking change check unless the label 'buf skip breaking' is set

breaking: ${{ github.event_name != 'pull_request' || !contains(github.event.pull_request.labels.*.name, 'buf skip breaking') }} # Enable breaking change check unless the label 'buf skip breaking' is set

So always check for breaking if it isn't a pull_request?

yeah. I think we want dev to always check? Well actually never mind because we might want breaking. Ignore me, not enough sleep :)

Ignore me, not enough sleep :)

ugh hear you on that

vbotbuildovich · 2025-12-05T16:50:11Z

Retry command for Build#77414

please wait until all jobs are finished before running the slash command

/ci-repeat 1
skip-redpanda-build
skip-units
skip-rebase
tests/rptest/tests/nodes_decommissioning_test.py::NodesDecommissioningTest.test_decommissioning_rebalancing_node@{"shutdown_decommissioned":false}

kbatuigas

Thank you, looks good from Docs

michael-redpanda · 2025-12-05T18:42:33Z

/ci-repeat 1
skip-redpanda-build
skip-units
skip-rebase
tests/rptest/tests/nodes_decommissioning_test.py::NodesDecommissioningTest.test_decommissioning_rebalancing_node@{"shutdown_decommissioned":false}

vbotbuildovich · 2025-12-05T19:39:14Z

/backport v25.3.x

vbotbuildovich · 2025-12-05T19:41:01Z

Failed to create a backport PR to v25.3.x branch. I tried:

git remote add upstream https://github.com/redpanda-data/redpanda.git
git fetch --all
git checkout -b backport-pr-28807-v25.3.x-636 remotes/upstream/v25.3.x
git cherry-pick -x 9aed824dfd a8f85839de

Workflow run logs.

michael-redpanda requested review from andrewstucki, r-vasquez and simon0191 December 2, 2025 21:56

michael-redpanda self-assigned this Dec 2, 2025

Copilot AI review requested due to automatic review settings December 2, 2025 21:56

michael-redpanda requested review from a team and rockwotj as code owners December 2, 2025 21:56

Copilot AI reviewed Dec 2, 2025

View reviewed changes

tests/rptest/clients/admin/proto/redpanda/core/admin/v2/__init__.pyi Show resolved Hide resolved

rockwotj reviewed Dec 3, 2025

View reviewed changes

proto/redpanda/core/admin/v2/shadow_link.proto Show resolved Hide resolved

michael-redpanda force-pushed the sl/alias-prefix branch from 6107344 to cdcb667 Compare December 3, 2025 12:57

michael-redpanda requested review from a team and kbatuigas as code owners December 3, 2025 12:57

michael-redpanda requested review from rpdevmp and removed request for a team December 3, 2025 12:57

github-actions bot added area/rpk area/build labels Dec 3, 2025

michael-redpanda requested review from Copilot and rockwotj December 3, 2025 12:58

Copilot AI reviewed Dec 3, 2025

View reviewed changes

.github/workflows/buf.yml Outdated Show resolved Hide resolved

michael-redpanda force-pushed the sl/alias-prefix branch from cdcb667 to 44eb7d1 Compare December 3, 2025 12:59

michael-redpanda requested a review from Copilot December 3, 2025 12:59

Copilot AI reviewed Dec 3, 2025

View reviewed changes

.github/workflows/buf.yml Outdated Show resolved Hide resolved

michael-redpanda force-pushed the sl/alias-prefix branch 2 times, most recently from d3b67b9 to 45ee926 Compare December 3, 2025 13:07

michael-redpanda requested a review from Copilot December 3, 2025 13:07

Copilot AI reviewed Dec 3, 2025

View reviewed changes

rockwotj previously approved these changes Dec 3, 2025

View reviewed changes

.github/workflows/buf.yml Outdated Show resolved Hide resolved

buf.yaml Outdated Show resolved Hide resolved

michael-redpanda dismissed rockwotj’s stale review via 73287a2 December 5, 2025 14:24

michael-redpanda force-pushed the sl/alias-prefix branch from 45ee926 to 73287a2 Compare December 5, 2025 14:24

michael-redpanda requested review from Copilot and rockwotj December 5, 2025 14:25

Copilot AI reviewed Dec 5, 2025

View reviewed changes

michael-redpanda added 2 commits December 5, 2025 09:26

buf: Enable breaking changes and permit enum alias

9aed824

Signed-off-by: Michael Boquard <[email protected]>

proto: Alias prefix and prefixed

a8f8583

To reduce confusion, this change introduces aliasing: * ACLPattern.ACL_PATTERN_PREFIX to ACLPattern.ACL_PATTERN_PREFIXED * PatternType.PATTERN_TYPE_PREFIXED to PatternType.PATTERN_TYPE_PREFIX Signed-off-by: Michael Boquard <[email protected]>

michael-redpanda force-pushed the sl/alias-prefix branch from 73287a2 to a8f8583 Compare December 5, 2025 14:26

rockwotj approved these changes Dec 5, 2025

View reviewed changes

michael-redpanda enabled auto-merge December 5, 2025 16:20

kbatuigas reviewed Dec 5, 2025

View reviewed changes

michael-redpanda merged commit aed7aa0 into redpanda-data:dev Dec 5, 2025
32 checks passed

vbotbuildovich mentioned this pull request Dec 5, 2025

[v25.3.x] proto: Alias prefix and prefixed #28875

Closed

michael-redpanda mentioned this pull request Dec 5, 2025

[v25.3.x] proto: Alias prefix and prefixed #28876

Merged

	breaking: ${{ github.event_name == 'pull_request' && !contains(github.event.pull_request.labels.*.name, 'buf skip breaking') }} # Enable breaking change check unless the label 'buf skip breaking' is set
	breaking: ${{ github.event_name != 'pull_request' \|\| !contains(github.event.pull_request.labels.*.name, 'buf skip breaking') }} # Enable breaking change check unless the label 'buf skip breaking' is set

proto: Alias prefix and prefixed #28807

proto: Alias prefix and prefixed #28807

Conversation

michael-redpanda commented Dec 2, 2025

Backports Required

Release Notes

Improvements

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

vbotbuildovich commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI test results

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

michael-redpanda commented Dec 5, 2025

Uh oh!

michael-redpanda commented Dec 5, 2025

Uh oh!

rockwotj Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

michael-redpanda Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

rockwotj Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

michael-redpanda Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

vbotbuildovich commented Dec 5, 2025

Retry command for Build#77414

Uh oh!

kbatuigas left a comment

Choose a reason for hiding this comment

Uh oh!

michael-redpanda commented Dec 5, 2025

Uh oh!

Uh oh!

vbotbuildovich commented Dec 5, 2025

Uh oh!

vbotbuildovich commented Dec 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

vbotbuildovich commented Dec 3, 2025 •

edited

Loading