Unify button handling for CustomContent #11169
Draft
+515
−541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasmerlin
changed the base branch from
main
to
lucas/list-item-consistent-buttons
lucasmerlin
added
the
exclude from changelog
|
Web viewer built successfully.
Note: This comment is updated whenever you push a commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
LabelContent,PropertyContentandSectionHeader#11164What
Implement the ItemButtons for CustomContent. This still has some problems around how overflow is handled (see the changed test image). I attempted to fix this using egui::Sides but this doesn't seem to fix anything yet. Maybe we could try to change the remember_property_content_max_width to work for all the content types.