-
Notifications
You must be signed in to change notification settings - Fork 585
Make InstancePose3D consistently interact with transform frames
#12021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Latest documentation preview deployed successfully.
Note: This comment is updated whenever you push a commit. |
|
Web viewer built successfully.
View image diff on kitdiff. Note: This comment is updated whenever you push a commit. |
1565631 to
27e7111
Compare
grtlr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, one of the last 🧩!
I just have some minor comments.
crates/viewer/re_view_spatial/src/contexts/transform_tree_context.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit unrelated, but: Would it make sense to set the SpatialInformation::show_axes view property for these tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure why not. But as pointed out before I'd rather keep those tests as isolated as possible. So a new show_axes property should get its own test suite
52ed62a to
578f7a7
Compare
Related
What
InstancePoses3Dis now again tracked on a per entity basis rather than being tied to a specific frame. This allows you to have many different poses that are all relative to the same frame.Example for illustrating purposes: (in a follow-up PR this example will be made available x-sdk)
Under the hood this means that we have to separate out tracking of poses to be entirely entity driven and combine them very late in the process: in fact the
re_tf::TransformForestno longer has any knowledge of these non-tree pose transforms. Instead, the per-viewTransformTreeContextis what picks them up and builds theTransformInfoobject that is used by visualizers - note that this PR simply moves outTransformInfofromre_tf, leaving behind a much simplerTreeTransformconstruct!