Xqci spec: add fixes for reported issues, update spec version to 0.5.0

[ayosher]

No description provided.

[ThinkOpenly]

I'm not qualified to review, but humbly request a more meaningful subject line and description for the first commit.

• "Add fixes for reported issues": I prefer something like "Fix X". Are there actual GitHub Issues being fixed? Then, in the commit description, describe what the issue(s) were, and how they were addressed.
• "update version to 0.5.0": Update version of what? Looking at the commit content, it appears "update Xqci extension version".

OR, is this commit entirely about updating the Xqci extension definition to to match version 0.5.0 of the extension specification? In other words, is it actually fixing errors in the implementation (incorrect implementation in this repository), or just incorporating the changes in a new version of the spec? If the latter, then the subject should simply be "Update Xqci extension to version 0.5.0".

Separately, are there significant implementations of all of the prior versions? Do we need to keep all of the information for all of the prior versions, or can we just keep the information for the latest version? I don't see the benefit of maintaining information for obsolete/draft versions of a specification.

[ayosher]

Paul, Thank you for your comment. This request is for Derek to review. It related to Xqci spec update to version 0.5.0. Actually, this riscv-unified-db is the actual (and only) source of Xqci specification. It is defined here. I will try to add better wording for any next commit comments, thank you for your input. Albert

…

________________________________ From: Paul Clarke ***@***.***> Sent: Tuesday, January 7, 2025 4:40 PM To: riscv-software-src/riscv-unified-db ***@***.***> Cc: Albert Yosher (QUIC) ***@***.***>; Author ***@***.***> Subject: Re: [riscv-software-src/riscv-unified-db] Add fixes for reported issues, update version to 0.5.0 (PR #384) WARNING: This email originated from outside of Qualcomm. Please be wary of any links or attachments, and do not enable macros. I'm not qualified to review, but humbly request a more meaningful subject line and description for the first commit. * "Add fixes for reported issues": I prefer something like "Fix X". Are there actual GitHub Issues being fixed? Then, in the commit description, describe what the issue(s) were, and how they were addressed. * "update version to 0.5.0": Update version of what? Looking at the commit content, it appears "update Xqci extension version". OR, is this commit entirely about updating the Xqci extension definition to to match version 0.5.0 of the extension specification? In other words, is it actually fixing errors in the implementation (incorrect implementation in this repository), or just incorporating the changes in a new version of the spec? If the latter, then the subject should simply be "Update Xqci extension to version 0.5.0". Separately, are there significant implementations of all of the prior versions? Do we need to keep all of the information for all of the prior versions, or can we just keep the information for the latest version? I don't see the benefit of maintaining information for obsolete/draft versions of a specification. — Reply to this email directly, view it on GitHub<#384 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BLMEF7S65ZHUD4SNLF7CJIT2JPRNFAVCNFSM6AAAAABUMHLXZKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZVGQ3DGMZTGY>. You are receiving this because you authored the thread.Message ID: ***@***.***>