feat(data): Add a few missing pseudoinstructions #717
Merged
+99
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AFOliveira
reviewed
May 2, 2025
Collaborator
There was a problem hiding this comment.
I don't think the pseudoinstructions to should be the assembly representation. Likely, the pseudoinstructions need a re-structure that allows that represenation, but for now I don't think we should place that information in a field that is not meant to accomodate it
dhower-qc
requested changes
May 5, 2025
AFOliveira
reviewed
May 6, 2025
Collaborator
AFOliveira
left a comment
AFOliveira
left a comment
There was a problem hiding this comment.
Other than the two whitespaces, I think all looks good!
Also fix a few places where integer registers were still being referred to as `r` instead of `x`. Also, fix a few operand specifications `csrrci` and `csrrsi` take "xd, csr, imm" not "rd, imm, rs1").
"zero" is not a constant in IDL. Also, add a comment to "fence" pseudoinstruction, since it maps to "fence" instruction with "iorw,iorw" operands.
dhower-qc
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.